'Re: Review Request: [Patch 2/2] Fix Sliding Popups'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: [Patch 2/2] Fix Sliding Popups
From:       "Commit Hook" <null () kde ! org>
Date:       2011-12-10 21:41:59
Message-ID: 20111210214159.4872.8753 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103367/#review8864
-----------------------------------------------------------

This review has been submitted with commit cbdd7295d100b19ec55d4b88f2a8113095439e26 \
by Martin Gräßlin to branch master.

- Commit Hook

On Dec. 10, 2011, 11:39 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103367/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2011, 11:39 a.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Description
> -------
> 
> Rework of sliding popups effect based on change to use "-1" as a default offset. \
> The animation is now calculated correctly (wasn't the case before) and clipping is \
> working again as the window quads are filtered out. 
> As a side note: I think we can now even try to apply blur behind the window during \
> the animation. I think that all tries before failed due to the fact that we just \
> calculated everything in the wrong way. 
> 
> This addresses bug 287602.
> http://bugs.kde.org/show_bug.cgi?id=287602
> 
> 
> Diffs
> -----
> 
> kwin/effects/slidingpopups/slidingpopups.cpp 1065bfc 
> 
> Diff: http://git.reviewboard.kde.org/r/103367/diff/diff
> 
> 
> Testing
> -------
> 
> yes, works for a panel on all possible corners (including panel between screens). \
> Nevertheless please all try this patch. 
> 
> Thanks,
> 
> Martin Gräßlin
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103367/">http://git.reviewboard.kde.org/r/103367/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit cbdd7295d100b19ec55d4b88f2a8113095439e26 by Martin Gräßlin to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On December 10th, 2011, 11:39 a.m., Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Plasma.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated Dec. 10, 2011, 11:39 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Rework of sliding popups effect based on change to use &quot;-1&quot; as \
a default offset. The animation is now calculated correctly (wasn&#39;t the case \
before) and clipping is working again as the window quads are filtered out.

As a side note: I think we can now even try to apply blur behind the window during \
the animation. I think that all tries before failed due to the fact that we just \
calculated everything in the wrong way.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">yes, works for a panel on all possible corners (including panel between \
screens). Nevertheless please all try this patch.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=287602">287602</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/effects/slidingpopups/slidingpopups.cpp <span style="color: \
grey">(1065bfc)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103367/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 