[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Blur behind animated sliding popups
From: "Commit Hook" <null () kde ! org>
Date: 2011-12-10 21:41:58
Message-ID: 20111210214158.4858.59098 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103375/#review8863
-----------------------------------------------------------
This review has been submitted with commit cd78335fef23c290a09fec29d7d9600f=
0076d63a by Martin Gr=C3=A4=C3=9Flin to branch master.
- Commit Hook
On Dec. 10, 2011, 12:43 p.m., Martin Gr=C3=A4=C3=9Flin wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103375/
> -----------------------------------------------------------
> =
> (Updated Dec. 10, 2011, 12:43 p.m.)
> =
> =
> Review request for kwin and Plasma.
> =
> =
> Description
> -------
> =
> Title says it all. This change allows to have the background of sliding p=
opups blurred. Tested, no artifacts on panels, also not with hard cases suc=
h as Yakuake.
> =
> Requires the other sliding popup related patches. As far as my system is =
concerned it has no impact on performance. Nevertheless I will try to make =
it work with the cached blur version.
> =
> As it might impact performance, I'm not sure whether this is 4.8 material=
. I let Aaron decide :-)
> =
> =
> Diffs
> -----
> =
> kwin/effects/blur/blur.cpp c566e34 =
> kwin/effects/slidingpopups/slidingpopups.cpp 1065bfc =
> =
> Diff: http://git.reviewboard.kde.org/r/103375/diff/diff
> =
> =
> Testing
> -------
> =
> =
> Screenshots
> -----------
> =
> Kickoff with blur during animation
> http://git.reviewboard.kde.org/r/103375/s/358/
> =
> =
> Thanks,
> =
> Martin Gr=C3=A4=C3=9Flin
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103375/">http://git.reviewboard.kde.org/r/103375/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit cd78335fef23c290a09fec29d7d9600f0076d63a by Martin Gräßlin to \
branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On December 10th, 2011, 12:43 p.m., Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Plasma.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Dec. 10, 2011, 12:43 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Title says it all. This change allows to have the background of sliding \
popups blurred. Tested, no artifacts on panels, also not with hard cases such as \
Yakuake.
Requires the other sliding popup related patches. As far as my system is concerned it \
has no impact on performance. Nevertheless I will try to make it work with the cached \
blur version.
As it might impact performance, I'm not sure whether this is 4.8 material. I let \
Aaron decide :-)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/effects/blur/blur.cpp <span style="color: grey">(c566e34)</span></li>
<li>kwin/effects/slidingpopups/slidingpopups.cpp <span style="color: \
grey">(1065bfc)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103375/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/103375/s/358/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/12/10/kickoff-animation_400x100.png" \
style="border: 1px black solid;" alt="Kickoff with blur during animation" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic