[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Allow Klipper to show on current mouse position
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2011-12-02 11:55:29
Message-ID: 20111202115529.28682.90180 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103196/#review8658
-----------------------------------------------------------
Ship it!
we're in string and feature freeze for 4.8, but this can go into master soon as 4.9 \
development is open.
klipper/klipper.cpp
<http://git.reviewboard.kde.org/r/103196/#comment7305>
i would suggest "at" instead of "on". perhaps: "Open klipper at current mouse \
position". if that is too long, drop "current" :)
- Aaron J. Seigo
On Nov. 23, 2011, 11:28 a.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103196/
> -----------------------------------------------------------
>
> (Updated Nov. 23, 2011, 11:28 a.m.)
>
>
> Review request for Plasma, Esben Mose Hansen and Sune Vuorela.
>
>
> Description
> -------
>
> This feature was present up until 4.3, then it got ported to the dbus menu and this \
> regression was never fixed. This is an easy fix returning back that functionality. \
> Fixes bug 254994.
> (I'm not sure to which group I should post this, so I left it empty)
>
>
> This addresses bug 254994.
> http://bugs.kde.org/show_bug.cgi?id=254994
>
>
> Diffs
> -----
>
> klipper/klipper.h e87595d
> klipper/klipper.cpp a588462
>
> Diff: http://git.reviewboard.kde.org/r/103196/diff/diff
>
>
> Testing
> -------
>
> Works.
>
>
> Thanks,
>
> Martin Klapetek
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103196/">http://git.reviewboard.kde.org/r/103196/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">we're in string and \
feature freeze for 4.8, but this can go into master soon as 4.9 development is \
open.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103196/diff/1/?file=41640#file41640line223" \
style="color: black; font-weight: bold; text-decoration: \
underline;">klipper/klipper.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">Klipper::Klipper(QObject *parent, const KSharedConfigPtr &config)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">223</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">m_showOnMousePos</span><span class="o">-></span><span \
class="n">setText</span><span class="p">(</span><span class="n">i18n</span><span \
class="p">(</span><span class="s">"Open Klipper on Mouse \
Position"</span><span class="p">));</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i would \
suggest "at" instead of "on". perhaps: "Open klipper at \
current mouse position". if that is too long, drop "current" :) </pre>
</div>
<br />
<p>- Aaron J.</p>
<br />
<p>On November 23rd, 2011, 11:28 a.m., Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Esben Mose Hansen and Sune Vuorela.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Nov. 23, 2011, 11:28 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This feature was present up until 4.3, then it got ported to the dbus \
menu and this regression was never fixed. This is an easy fix returning back that \
functionality. Fixes bug 254994.
(I'm not sure to which group I should post this, so I left it empty)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=254994">254994</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>klipper/klipper.h <span style="color: grey">(e87595d)</span></li>
<li>klipper/klipper.cpp <span style="color: grey">(a588462)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103196/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic