[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Allow Klipper to show on current mouse position
From: "Martin Klapetek" <martin.klapetek () gmail ! com>
Date: 2011-11-23 11:28:20
Message-ID: 20111123112820.10507.67248 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103196/
-----------------------------------------------------------
(Updated Nov. 23, 2011, 11:28 a.m.)
Review request for Plasma, Esben Mose Hansen and Sune Vuorela.
Changes
-------
Since this has been here for two days without reaction and since there is no \
"workspace" review group, I'm adding plasma as it is _the_ workspace :) Should this \
be put for a different group, please let me know which one.
Thanks.
Description
-------
This feature was present up until 4.3, then it got ported to the dbus menu and this \
regression was never fixed. This is an easy fix returning back that functionality. \
Fixes bug 254994.
(I'm not sure to which group I should post this, so I left it empty)
This addresses bug 254994.
http://bugs.kde.org/show_bug.cgi?id=254994
Diffs
-----
klipper/klipper.h e87595d
klipper/klipper.cpp a588462
Diff: http://git.reviewboard.kde.org/r/103196/diff/diff
Testing
-------
Works.
Thanks,
Martin Klapetek
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103196/">http://git.reviewboard.kde.org/r/103196/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Esben Mose Hansen and Sune Vuorela.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Nov. 23, 2011, 11:28 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Since this has been here for two days without reaction and since there \
is no "workspace" review group, I'm adding plasma as it is _the_ \
workspace :) Should this be put for a different group, please let me know which one.
Thanks.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This feature was present up until 4.3, then it got ported to the dbus \
menu and this regression was never fixed. This is an easy fix returning back that \
functionality. Fixes bug 254994.
(I'm not sure to which group I should post this, so I left it empty)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=254994">254994</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>klipper/klipper.h <span style="color: grey">(e87595d)</span></li>
<li>klipper/klipper.cpp <span style="color: grey">(a588462)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103196/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic