[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Plasmate:images can now be added to projects
From: "Giorgos Tsiapaliwkas" <terietor () gmail ! com>
Date: 2011-11-28 13:50:39
Message-ID: 20111128135039.16288.88700 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102290/
-----------------------------------------------------------
(Updated Nov. 28, 2011, 1:50 p.m.)
Review request for Plasma and Aaron J. Seigo.
Changes
-------
Because i didn't want to add a TODO,i tried to complete the patch.
The point is the during QThreadPool::globalInstance()->start(m_imageViewer)=
a seg fault occurs.
Can you help me?
Description
-------
hello,
without this patch a user cannot add an image with plasmate.
reproduce,go to files-images-new,the plasmate will open a text editor inste=
ad of a dialog,which(the dialog) is able to open an image.
With the patch a dialog will open asking for an image.
Diffs (updated)
-----
CMakeLists.txt e825271 =
editors/CMakeLists.txt 1feb1ce =
editors/editpage.h 7b5dca3 =
editors/editpage.cpp d4b0082 =
editors/imageviewer/imageviewer.h e69de29 =
editors/imageviewer/imageviewer.cpp e69de29 =
main.cpp 66a7cd8 =
mainwindow.h 7d89815 =
mainwindow.cpp 6ea7f0c =
packagemodel.cpp 8c0907a =
Diff: http://git.reviewboard.kde.org/r/102290/diff/diff
Testing
-------
the patch is not ready yet,i have noted some questions.
Also the plasmate tries to open the image with a text editor.This have to b=
e fixed,but how?Should we make plasmate able to preview images?
In addition,when you add something in the list of files(using the different=
options provided by the files qdockwidget) it names it as "new".This has t=
o be fixed and the plasmate has to show the real name of the file.(differen=
t request,i just want an approval for this patch).
Thanks,
Giorgos Tsiapaliwkas
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102290/">http://git.reviewboard.kde.org/r/102290/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Aaron J. Seigo.</div>
<div>By Giorgos Tsiapaliwkas.</div>
<p style="color: grey;"><i>Updated Nov. 28, 2011, 1:50 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Because i didn't want to add a TODO,i tried to complete the patch. \
The point is the during QThreadPool::globalInstance()->start(m_imageViewer) a seg \
fault occurs. Can you help me?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">hello,
without this patch a user cannot add an image with plasmate.
reproduce,go to files-images-new,the plasmate will open a text editor instead of a \
dialog,which(the dialog) is able to open an image.
With the patch a dialog will open asking for an image.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">the patch is not ready yet,i have noted some questions. Also the \
plasmate tries to open the image with a text editor.This have to be fixed,but \
how?Should we make plasmate able to preview images?
In addition,when you add something in the list of files(using the different options \
provided by the files qdockwidget) it names it as "new".This has to be \
fixed and the plasmate has to show the real name of the file.(different request,i \
just want an approval for this patch).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(e825271)</span></li>
<li>editors/CMakeLists.txt <span style="color: grey">(1feb1ce)</span></li>
<li>editors/editpage.h <span style="color: grey">(7b5dca3)</span></li>
<li>editors/editpage.cpp <span style="color: grey">(d4b0082)</span></li>
<li>editors/imageviewer/imageviewer.h <span style="color: \
grey">(e69de29)</span></li>
<li>editors/imageviewer/imageviewer.cpp <span style="color: \
grey">(e69de29)</span></li>
<li>main.cpp <span style="color: grey">(66a7cd8)</span></li>
<li>mainwindow.h <span style="color: grey">(7d89815)</span></li>
<li>mainwindow.cpp <span style="color: grey">(6ea7f0c)</span></li>
<li>packagemodel.cpp <span style="color: grey">(8c0907a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102290/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic