[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Plasmate:images can now be added to projects
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2011-11-16 16:51:45
Message-ID: 20111116165145.8433.13907 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102290/#review8234
-----------------------------------------------------------
Ship it!
to minor issues and this can go in...
editors/imageviewer/imageviewer.cpp
<http://git.reviewboard.kde.org/r/102290/#comment7035>
this probably should be threaded; but that can be done later. can you i=
nsert a TODO comment here noting this? thanks :)
packagemodel.cpp
<http://git.reviewboard.kde.org/r/102290/#comment7034>
incorrect indentation.
- Aaron J. Seigo
On Oct. 30, 2011, 7:48 a.m., Giorgos Tsiapaliwkas wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102290/
> -----------------------------------------------------------
> =
> (Updated Oct. 30, 2011, 7:48 a.m.)
> =
> =
> Review request for Plasma and Aaron J. Seigo.
> =
> =
> Description
> -------
> =
> hello,
> =
> without this patch a user cannot add an image with plasmate.
> =
> reproduce,go to files-images-new,the plasmate will open a text editor ins=
tead of a dialog,which(the dialog) is able to open an image.
> =
> With the patch a dialog will open asking for an image.
> =
> =
> Diffs
> -----
> =
> CMakeLists.txt f3f32a9 =
> editors/editpage.h 7b5dca3 =
> editors/editpage.cpp d4b0082 =
> editors/imageviewer/imageviewer.h e69de29 =
> editors/imageviewer/imageviewer.cpp e69de29 =
> main.cpp 66a7cd8 =
> mainwindow.h 1b1c2a2 =
> mainwindow.cpp 2fa2742 =
> packagemodel.cpp 8c0907a =
> =
> Diff: http://git.reviewboard.kde.org/r/102290/diff/diff
> =
> =
> Testing
> -------
> =
> the patch is not ready yet,i have noted some questions.
> Also the plasmate tries to open the image with a text editor.This have to=
be fixed,but how?Should we make plasmate able to preview images?
> =
> In addition,when you add something in the list of files(using the differe=
nt options provided by the files qdockwidget) it names it as "new".This has=
to be fixed and the plasmate has to show the real name of the file.(differ=
ent request,i just want an approval for this patch).
> =
> =
> Thanks,
> =
> Giorgos Tsiapaliwkas
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102290/">http://git.reviewboard.kde.org/r/102290/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">to minor issues and this \
can go in...</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/102290/diff/4/?file=39875#file39875line54" \
style="color: black; font-weight: bold; text-decoration: \
underline;">editors/imageviewer/imageviewer.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">void ImageViewer::setImage(const KUrl& image)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">54</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QPixmap</span> <span class="n">pixmap</span><span \
class="p">;</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">55</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">pixmap</span><span class="p">.</span><span class="n">load</span><span \
class="p">(</span><span class="n">m_image</span><span class="p">,</span><span \
class="s">"PNG JPG GIF JPEG"</span><span class="p">);</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this \
probably should be threaded; but that can be done later. can you insert a TODO \
comment here noting this? thanks :)</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/102290/diff/4/?file=39879#file39879line178" \
style="color: black; font-weight: bold; text-decoration: \
underline;">packagemodel.cpp</a> <span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">QVariant PackageModel::data(const QModelIndex &index, int role) \
const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">178</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">if</span> <span class="p">(</span><span class="o">!</span><span \
class="n">qstrcmp</span><span class="p">(</span><span class="n">key</span><span \
class="p">,</span> <span class="s">"images"</span><span class="p">))</span> \
<span class="p">{</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">179</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">return</span> <span class="n">QStringList</span><span \
class="p">(</span><span class="s">"[plasmate]/imageViewer"</span><span \
class="p">);</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">180</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="p">}</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">incorrect \
indentation.</pre> </div>
<br />
<p>- Aaron J.</p>
<br />
<p>On October 30th, 2011, 7:48 a.m., Giorgos Tsiapaliwkas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Aaron J. Seigo.</div>
<div>By Giorgos Tsiapaliwkas.</div>
<p style="color: grey;"><i>Updated Oct. 30, 2011, 7:48 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">hello,
without this patch a user cannot add an image with plasmate.
reproduce,go to files-images-new,the plasmate will open a text editor instead of a \
dialog,which(the dialog) is able to open an image.
With the patch a dialog will open asking for an image.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">the patch is not ready yet,i have noted some questions. Also the \
plasmate tries to open the image with a text editor.This have to be fixed,but \
how?Should we make plasmate able to preview images?
In addition,when you add something in the list of files(using the different options \
provided by the files qdockwidget) it names it as "new".This has to be \
fixed and the plasmate has to show the real name of the file.(different request,i \
just want an approval for this patch).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(f3f32a9)</span></li>
<li>editors/editpage.h <span style="color: grey">(7b5dca3)</span></li>
<li>editors/editpage.cpp <span style="color: grey">(d4b0082)</span></li>
<li>editors/imageviewer/imageviewer.h <span style="color: \
grey">(e69de29)</span></li>
<li>editors/imageviewer/imageviewer.cpp <span style="color: \
grey">(e69de29)</span></li>
<li>main.cpp <span style="color: grey">(66a7cd8)</span></li>
<li>mainwindow.h <span style="color: grey">(1b1c2a2)</span></li>
<li>mainwindow.cpp <span style="color: grey">(2fa2742)</span></li>
<li>packagemodel.cpp <span style="color: grey">(8c0907a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102290/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic