[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Bug fix for 278765
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2011-11-22 10:14:50
Message-ID: 20111122101450.11398.23914 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Nov. 16, 2011, 5 p.m., Aaron J. Seigo wrote:
> > plasma/desktop/applets/tasks/abstracttaskitem.cpp, lines 172-176
> > <http://git.reviewboard.kde.org/r/102304/diff/2/?file=37695#file37695line172>
> >
> > much simpler is:
> >
> > data.setInstantPopup(KWindowSystem::compositingActive());
> >
> > it does the same thing after all :)
>
> Aaron J. Seigo wrote:
> to increase the timeout for zero to an arbitrary value would require allowing \
> Plasma::ToolTipData to take a timeout. i do not want to see that as it means we'll \
> end up with these "special" timeouts (and higher maintenance and impossible to keep \
> consistency) throughout plasma using code.
> instead, i'd prefer to see instant popups behave more sanely (a small timeout \
> rather than a zero one, for instance). that code is in Plasma::ToolTipManager and \
> is what should be altered.
> Giorgos Tsiapaliwkas wrote:
> I updated the diff according to Aaron's advice.
>
> So if i understood correctly this patch is ready and the Plasma::ToolTipManager.Is \
> another patch.
> thanks
yes, the tooltipmanager would be a different patch and would need to happen in the \
frameworks branch against libplasma2 since it is a new feature and not really a bug \
fix.
- Aaron J.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102304/#review8236
-----------------------------------------------------------
On Nov. 22, 2011, 7:57 a.m., Giorgos Tsiapaliwkas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102304/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2011, 7:57 a.m.)
>
>
> Review request for Plasma and Aaron J. Seigo.
>
>
> Description
> -------
>
> hello,
>
> I found a third solution for this bug(Aaron said the other two at tha plasma-devel \
> mailing list).
>
> This addresses bug 278765.
> http://bugs.kde.org/show_bug.cgi?id=278765
>
>
> Diffs
> -----
>
> plasma/desktop/applets/tasks/abstracttaskitem.cpp 48ba172
> plasma/desktop/applets/tasks/applauncheritem.cpp 4dc24ee
> plasma/desktop/applets/tasks/taskgroupitem.cpp d7816d3
> plasma/desktop/applets/tasks/windowtaskitem.cpp c4db8c7
>
> Diff: http://git.reviewboard.kde.org/r/102304/diff/diff
>
>
> Testing
> -------
>
> compiles fines
>
>
> Thanks,
>
> Giorgos Tsiapaliwkas
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102304/">http://git.reviewboard.kde.org/r/102304/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 16th, 2011, 5 p.m., <b>Aaron J. \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/102304/diff/2/?file=37695#file37695line172" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/desktop/applets/tasks/abstracttaskitem.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
AbstractTaskItem::checkSettings()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">172</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span><span class="p">(</span><span class="o">!</span><span \
class="n">KWindowSystem</span><span class="o">::</span><span \
class="n">compositingActive</span><span class="p">())</span> <span \
class="p">{</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">173</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">data</span><span class="p">.</span><span \
class="n">setInstantPopup</span><span class="p">(</span><span \
class="kc">false</span><span class="p">);</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">174</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="p">}</span> <span class="k">else</span> <span class="p">{</span></pre></td> \
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">171</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">data</span><span class="p">.</span><span \
class="n">setInstantPopup</span><span class="p">(</span><span \
class="kc">true</span><span class="p">);</span></pre></td> <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">175</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">data</span><span class="p">.</span><span \
class="n">setInstantPopup</span><span class="p">(</span><span \
class="kc">true</span><span class="p">);</span></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">176</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="p">}</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">much simpler is:
data.setInstantPopup(KWindowSystem::compositingActive());
it does the same thing after all :)</pre>
</blockquote>
<p>On November 16th, 2011, 5:03 p.m., <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">to increase the timeout \
for zero to an arbitrary value would require allowing Plasma::ToolTipData to take a \
timeout. i do not want to see that as it means we'll end up with these \
"special" timeouts (and higher maintenance and impossible to keep \
consistency) throughout plasma using code.
instead, i'd prefer to see instant popups behave more sanely (a small timeout \
rather than a zero one, for instance). that code is in Plasma::ToolTipManager and is \
what should be altered.</pre> </blockquote>
<p>On November 22nd, 2011, 7:57 a.m., <b>Giorgos Tsiapaliwkas</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I updated the diff \
according to Aaron's advice.
So if i understood correctly this patch is ready and the Plasma::ToolTipManager.Is \
another patch.
thanks</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yes, the \
tooltipmanager would be a different patch and would need to happen in the frameworks \
branch against libplasma2 since it is a new feature and not really a bug fix.</pre> \
<br />
<p>- Aaron J.</p>
<br />
<p>On November 22nd, 2011, 7:57 a.m., Giorgos Tsiapaliwkas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Aaron J. Seigo.</div>
<div>By Giorgos Tsiapaliwkas.</div>
<p style="color: grey;"><i>Updated Nov. 22, 2011, 7:57 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">hello,
I found a third solution for this bug(Aaron said the other two at tha plasma-devel \
mailing list).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">compiles fines</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=278765">278765</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/desktop/applets/tasks/abstracttaskitem.cpp <span style="color: \
grey">(48ba172)</span></li>
<li>plasma/desktop/applets/tasks/applauncheritem.cpp <span style="color: \
grey">(4dc24ee)</span></li>
<li>plasma/desktop/applets/tasks/taskgroupitem.cpp <span style="color: \
grey">(d7816d3)</span></li>
<li>plasma/desktop/applets/tasks/windowtaskitem.cpp <span style="color: \
grey">(c4db8c7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102304/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic