From kde-panel-devel Tue Nov 22 10:14:50 2011 From: "Aaron J. Seigo" Date: Tue, 22 Nov 2011 10:14:50 +0000 To: kde-panel-devel Subject: Re: Review Request: Bug fix for 278765 Message-Id: <20111122101450.11398.23914 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=132195698523704 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2702216522349215417==" --===============2702216522349215417== Content-Type: multipart/alternative; boundary="===============2057755599186547347==" --===============2057755599186547347== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Nov. 16, 2011, 5 p.m., Aaron J. Seigo wrote: > > plasma/desktop/applets/tasks/abstracttaskitem.cpp, lines 172-176 > > > > > > much simpler is: > > = > > data.setInstantPopup(KWindowSystem::compositingActive()); > > = > > it does the same thing after all :) > = > Aaron J. Seigo wrote: > to increase the timeout for zero to an arbitrary value would require = allowing Plasma::ToolTipData to take a timeout. i do not want to see that a= s it means we'll end up with these "special" timeouts (and higher maintenan= ce and impossible to keep consistency) throughout plasma using code. > = > instead, i'd prefer to see instant popups behave more sanely (a small= timeout rather than a zero one, for instance). that code is in Plasma::Too= lTipManager and is what should be altered. > = > Giorgos Tsiapaliwkas wrote: > I updated the diff according to Aaron's advice. > = > So if i understood correctly this patch is ready and the Plasma::Tool= TipManager.Is another patch. > = > thanks yes, the tooltipmanager would be a different patch and would need to happen= in the frameworks branch against libplasma2 since it is a new feature and = not really a bug fix. - Aaron J. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102304/#review8236 ----------------------------------------------------------- On Nov. 22, 2011, 7:57 a.m., Giorgos Tsiapaliwkas wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102304/ > ----------------------------------------------------------- > = > (Updated Nov. 22, 2011, 7:57 a.m.) > = > = > Review request for Plasma and Aaron J. Seigo. > = > = > Description > ------- > = > hello, > = > I found a third solution for this bug(Aaron said the other two at tha pla= sma-devel mailing list). > = > = > This addresses bug 278765. > http://bugs.kde.org/show_bug.cgi?id=3D278765 > = > = > Diffs > ----- > = > plasma/desktop/applets/tasks/abstracttaskitem.cpp 48ba172 = > plasma/desktop/applets/tasks/applauncheritem.cpp 4dc24ee = > plasma/desktop/applets/tasks/taskgroupitem.cpp d7816d3 = > plasma/desktop/applets/tasks/windowtaskitem.cpp c4db8c7 = > = > Diff: http://git.reviewboard.kde.org/r/102304/diff/diff > = > = > Testing > ------- > = > compiles fines > = > = > Thanks, > = > Giorgos Tsiapaliwkas > = > --===============2057755599186547347== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/102304/

On November 16th, 2011, 5 p.m., Aaron J. Se= igo wrote:

= = = = = = =

plasma/desktop/applets/tasks/abstracttaskitem.cpp (Diff revision 2)
void AbstractTaskItem::checkSettings()
		172	if(!KWindowSystem= ::compositingActive()) {
		173	data.setInstantPopup= (false);
		174	} else {
171	data.setInstantPopup(<= /span>true);	175	data.setInstantPopup= (true);
		176	}

much simp=
ler is:

data.setInstantPopup(KWindowSystem::compositingActive());

it does the same thing after all :)

On November 16th, 2011, 5:03 p.m., Aaron J. Seigo wrote:

to increa=
se the timeout for zero to an arbitrary value would require allowing Plasma=
::ToolTipData to take a timeout. i do not want to see that as it means we&#=
39;ll end up with these "special" timeouts (and higher maintenanc=
e and impossible to keep consistency) throughout plasma using code.

instead, i'd prefer to see instant popups behave more sanely (a small t=
imeout rather than a zero one, for instance). that code is in Plasma::ToolT=
ipManager and is what should be altered.

On November 22nd, 2011, 7:57 a.m., Giorgos Tsiapaliwkas wrote:

I updated=
 the diff according to Aaron's advice.

So if i understood correctly this patch is ready and the Plasma::ToolTipMan=
ager.Is another patch.

thanks

yes, the tooltipmanager would be a different patch and would need to=
 happen in the frameworks branch against libplasma2 since it is a new featu=
re and not really a bug fix.

- Aaron J.

On November 22nd, 2011, 7:57 a.m., Giorgos Tsiapaliwkas wrote:

Review request for Plasma and Aaron J. Seigo.

By Giorgos Tsiapaliwkas.

Updated Nov. 22, 2011, 7:57 a.m.

Descripti= on

hello,

I found a third solution for this bug(Aaron said the other two at tha plasm=
a-devel mailing list).

Testing <= /h1>

compiles fines

Bugs: 278765

Diffs=

plasma/desktop/applets/tasks/abstracttaskitem.cpp (48ba172)
plasma/desktop/applets/tasks/applauncheritem.cpp (4dc24ee)
plasma/desktop/applets/tasks/taskgroupitem.cpp (d7816d3)
plasma/desktop/applets/tasks/windowtaskitem.cpp (c4db8c7)

--===============2057755599186547347==-- --===============2702216522349215417== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============2702216522349215417==--