[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Adjust KDateTimes to Current TimeSpec of the
From: "John Layt" <john () layt ! net>
Date: 2011-11-09 21:56:03
Message-ID: 20111109215603.28726.18315 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Nov. 9, 2011, 10:33 a.m., David Narváez wrote:
> > If there are no more comments against or in favor of this patch, I'm assuming \
> > everyone is OK with it so I'll commit this patch.
>
> Sergio Luis Martins wrote:
> Ok.
>
> Please add a note in the TODO that we'll need to look at this again when using the \
> kdepimlibs library.
TBH, I'd rather not change anything in the Akonadi code that causes it to be out of \
sync with the kdepim code, as that will just make keeping them in sync and applying \
patches from kdepim harder to do. It also adds more work later when switching over \
to the kdepimlibs version. I think this belongs instead in the Data Engine. The \
Data Engine should be the one making any required adjustments to translate between \
the data source and the applet request. We can't expect the average applet to know \
to deal with the issue correctly, that's exactly what the data engine is for.
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102997/#review8038
-----------------------------------------------------------
On Nov. 8, 2011, 9:14 a.m., David Narváez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102997/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2011, 9:14 a.m.)
>
>
> Review request for Plasma and Sergio Luis Martins.
>
>
> Description
> -------
>
> Adjust KDateTimes after finding out the type of incidence added. Also adjust \
> KDateTimes after a change in the Calendar TimeSpec.
>
> This addresses bug 279427.
> http://bugs.kde.org/show_bug.cgi?id=279427
>
>
> Diffs
> -----
>
> plasma/generic/dataengines/calendar/akonadi/calendar.cpp 67c12e9
>
> Diff: http://git.reviewboard.kde.org/r/102997/diff/diff
>
>
> Testing
> -------
>
> 1. Add an event in any timezone distinct from the local timezone (you can do that \
> in KOrganizer) 2. Check the start and end times of the event in the calendar
>
> Not sure how to test changing timezones from Plasma, so proposed patch is based on \
> what I think we should do in such a case.
>
> Thanks,
>
> David Narváez
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102997/">http://git.reviewboard.kde.org/r/102997/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 9th, 2011, 10:33 a.m., <b>David \
Narváez</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">If there are no more comments against or in favor of this patch, I'm \
assuming everyone is OK with it so I'll commit this patch.</pre> </blockquote>
<p>On November 9th, 2011, 8:12 p.m., <b>Sergio Luis Martins</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok.
Please add a note in the TODO that we'll need to look at this again when using \
the kdepimlibs library.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">TBH, I'd rather not \
change anything in the Akonadi code that causes it to be out of sync with the kdepim \
code, as that will just make keeping them in sync and applying patches from kdepim \
harder to do. It also adds more work later when switching over to the kdepimlibs \
version. I think this belongs instead in the Data Engine. The Data Engine should be \
the one making any required adjustments to translate between the data source and the \
applet request. We can't expect the average applet to know to deal with the \
issue correctly, that's exactly what the data engine is for.</pre> <br />
<p>- John</p>
<br />
<p>On November 8th, 2011, 9:14 a.m., David Narváez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Sergio Luis Martins.</div>
<div>By David Narváez.</div>
<p style="color: grey;"><i>Updated Nov. 8, 2011, 9:14 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Adjust KDateTimes after finding out the type of incidence added. Also \
adjust KDateTimes after a change in the Calendar TimeSpec.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">1. Add an event in any timezone distinct from the local timezone (you \
can do that in KOrganizer) 2. Check the start and end times of the event in the \
calendar
Not sure how to test changing timezones from Plasma, so proposed patch is based on \
what I think we should do in such a case.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=279427">279427</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/dataengines/calendar/akonadi/calendar.cpp <span style="color: \
grey">(67c12e9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102997/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic