[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Make IconTask use Plasma::Theme'd "close" button
From: "Commit Hook" <null () kde ! org>
Date: 2011-11-09 20:50:07
Message-ID: 20111109205007.21020.73648 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103092/#review8061
-----------------------------------------------------------
This review has been submitted with commit e38d61795c3eb58d14c27df43970965d=
d568f952 by Diego [Po]lentino Casella to branch master.
- Commit Hook
On Nov. 9, 2011, 4:33 p.m., Diego Casella wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103092/
> -----------------------------------------------------------
> =
> (Updated Nov. 9, 2011, 4:33 p.m.)
> =
> =
> Review request for Plasma and Craig Drummond.
> =
> =
> Description
> -------
> =
> Simple patch which makes IconTask look more consistent with Plasma Theme.
> It renders the "close" button using Plasma::Theme, and fallback to the st=
andard window-close icon if nothing better is available :)
> =
> =
> Diffs
> -----
> =
> applets/icontasks/tooltips/windowpreview.cpp 3e0c865 =
> =
> Diff: http://git.reviewboard.kde.org/r/103092/diff/diff
> =
> =
> Testing
> -------
> =
> Compiles and works as expected (see pictures below).
> =
> =
> Screenshots
> -----------
> =
> ToolTip with themed "close" button
> http://git.reviewboard.kde.org/r/103092/s/329/
> ToolTip with default "close" icon
> http://git.reviewboard.kde.org/r/103092/s/330/
> ToolTip with themed "closed" button, resized
> http://git.reviewboard.kde.org/r/103092/s/331/
> =
> =
> Thanks,
> =
> Diego Casella
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103092/">http://git.reviewboard.kde.org/r/103092/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit e38d61795c3eb58d14c27df43970965dd568f952 by Diego [Po]lentino \
Casella to branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On November 9th, 2011, 4:33 p.m., Diego Casella wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Craig Drummond.</div>
<div>By Diego Casella.</div>
<p style="color: grey;"><i>Updated Nov. 9, 2011, 4:33 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Simple patch which makes IconTask look more consistent with Plasma \
Theme. It renders the "close" button using Plasma::Theme, and fallback to \
the standard window-close icon if nothing better is available :)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiles and works as expected (see pictures below).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/icontasks/tooltips/windowpreview.cpp <span style="color: \
grey">(3e0c865)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103092/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/103092/s/329/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/11/09/icontask_close_button_1_400x100.png" \
style="border: 1px black solid;" alt="ToolTip with themed "close" button" \
/></a>
<a href="http://git.reviewboard.kde.org/r/103092/s/330/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/11/09/icontask_close_button1_400x100.png" \
style="border: 1px black solid;" alt="ToolTip with default "close" icon" \
/></a>
<a href="http://git.reviewboard.kde.org/r/103092/s/331/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/11/09/icontask_close_button3_400x100.png" \
style="border: 1px black solid;" alt="ToolTip with themed "closed" button, \
resized" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic