'Re: Review Request: TaskManager: TaskAction changes from IconTasks'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: TaskManager: TaskAction changes from IconTasks
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2011-11-01 14:05:08
Message-ID: 20111101140508.10359.95900 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103004/#review7794
-----------------------------------------------------------

a few issues with this patch, which can be divided into three types:

* over simplification of the menu; i am all for reducing the items in this menu, \
including moving more to the "Advanced" submenu (which should probably be renamed to \
"More Actions"), but this patch goes too far and renders the BasicMenu far, far les \
                useful than it ought to be
* custom properties in the QActions are unneeded (see inline comments for how these \
                can be handled without custom properties)
* whitespace correctness (the most trivial and least important of the issues)

libs/taskmanager/taskactions.cpp
<http://git.reviewboard.kde.org/r/103004/#comment6689>

    please watch whitespace usage. this should be:

    if (QEvent:: ..) {

    also, no extra space at the end of lines, please.

    this needs to be addressed throughout the patch. i know it's finicky work, but it \
pays off with code readability at the end.

libs/taskmanager/taskactions.cpp
<http://git.reviewboard.kde.org/r/103004/#comment6688>

    why a property for this? why not simply:

    if (!act->toolTip().isEmpty()) {

libs/taskmanager/taskactions.cpp
<http://git.reviewboard.kde.org/r/103004/#comment6690>

    we have a name, it should be used. it hardly matters what the eventual Launcher \
is called. shortening it with the removal of "It Is" is probably alright ("computer \
application english" :)

libs/taskmanager/taskactions.cpp
<http://git.reviewboard.kde.org/r/103004/#comment6693>

    how well does this work with KUniqueApplications?

libs/taskmanager/taskactions.cpp
<http://git.reviewboard.kde.org/r/103004/#comment6692>

    whitespace around ==

libs/taskmanager/taskactions.cpp
<http://git.reviewboard.kde.org/r/103004/#comment6691>

    should be on same line

libs/taskmanager/taskactions.cpp
<http://git.reviewboard.kde.org/r/103004/#comment6694>

    ws

libs/taskmanager/taskactions.cpp
<http://git.reviewboard.kde.org/r/103004/#comment6695>

    ws

libs/taskmanager/taskactions.cpp
<http://git.reviewboard.kde.org/r/103004/#comment6696>

    there's a line between "simplifiying" and "making it useless in too many cases" \
that this crosses imho. this would have me reaching for the window titlebar in too \
many cases.  
    i would be in favour of renaming "Advanced" (a word we are trying to get away \
from) with something like "More actions"

libs/taskmanager/taskactions.cpp
<http://git.reviewboard.kde.org/r/103004/#comment6698>

    with this change one has to open the goup, right click on the correct entry and \
then choose. i don't see the point of this simlification other than to make it harder \
to get at.

libs/taskmanager/taskactions.cpp
<http://git.reviewboard.kde.org/r/103004/#comment6699>

    no, this is one of the PRIMARY uses of the context menu. what would be nice is to \
move "To Current Desktop" into the DesktopsMenu, however, right above "All Desktops"

libs/taskmanager/taskactions.cpp
<http://git.reviewboard.kde.org/r/103004/#comment6700>

    could be moved into the "Advanced"(/"More Actions") menu?

libs/taskmanager/taskactions.cpp
<http://git.reviewboard.kde.org/r/103004/#comment6701>

    again, this is just crippling the menu, not making it "simpler"

libs/taskmanager/taskactions.cpp
<http://git.reviewboard.kde.org/r/103004/#comment6702>

    you should be able to just  menu->addAction(action) for the separator case?

libs/taskmanager/taskactions.cpp
<http://git.reviewboard.kde.org/r/103004/#comment6703>

    this is a misuse of QAction. you can add QActions to a QAction and that parent \
QAction becomes the submenu. no need for such custom property setting/reading and \
menu creation.

- Aaron J. Seigo

On Oct. 31, 2011, 8:40 p.m., Craig Drummond wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103004/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2011, 8:40 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> 1. Add NewInstance action to launch a new instance of an application.
> 2. Move toggle launcher action out of advanced menu.
> 3. Don't show application name in 'Show A Launcher' action, as might not know the \
> real name at this time (e.g. no desktop file read). 4. Add application actions, to \
> be shown at the top of the right-click menu. IconTasks uses this to show recent \
> docuents, dock manager menu items, and unity items. 5. A ToolTipMenu class is \
> created, so that tooltips may be give for menu items. This is so that IconTasks can \
> display the full path of a documents in the recent documents menu. 6. Add option to \
> have only basic window controls in menu. 
> 
> Diffs
> -----
> 
> libs/taskmanager/taskactions.h 2b5a641 
> libs/taskmanager/taskactions.cpp 0e6ba8e 
> libs/taskmanager/taskactions_p.h 913966c 
> 
> Diff: http://git.reviewboard.kde.org/r/103004/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Craig Drummond
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103004/">http://git.reviewboard.kde.org/r/103004/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">a few issues with this \
patch, which can be divided into three types:

* over simplification of the menu; i am all for reducing the items in this menu, \
including moving more to the &quot;Advanced&quot; submenu (which should probably be \
renamed to &quot;More Actions&quot;), but this patch goes too far and renders the \
                BasicMenu far, far les useful than it ought to be
* custom properties in the QActions are unneeded (see inline comments for how these \
                can be handled without custom properties)
* whitespace correctness (the most trivial and least important of the issues)</pre>
 <br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/103004/diff/1/?file=39919#file39919line130" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libs/taskmanager/taskactions.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">bool ToolTipMenu::event(QEvent* e)</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">130</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="k">if</span><span class="p">(</span><span class="n">QEvent</span><span \
class="o">::</span><span class="n">ToolTip</span><span class="o">==</span><span \
class="n">e</span><span class="o">-&gt;</span><span class="n">type</span><span \
class="p">())</span> <span class="p">{</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">please \
watch whitespace usage. this should be:

if (QEvent:: ..) {

also, no extra space at the end of lines, please.

this needs to be addressed throughout the patch. i know it&#39;s finicky work, but it \
pays off with code readability at the end.</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/103004/diff/1/?file=39919#file39919line135" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libs/taskmanager/taskactions.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">bool ToolTipMenu::event(QEvent* e)</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">135</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">            \
<span class="k">if</span><span class="p">(</span><span class="n">act</span><span \
class="o">-&gt;</span><span class="n">property</span><span class="p">(</span><span \
class="s">&quot;show-tooltip&quot;</span><span class="p">).</span><span \
class="n">toBool</span><span class="p">())</span> <span class="p">{</span></pre></td> \
</tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">why a \
property for this? why not simply:

if (!act-&gt;toolTip().isEmpty()) {</pre>
</div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/103004/diff/1/?file=39919#file39919line384" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libs/taskmanager/taskactions.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">ToggleLauncherActionImpl::ToggleLauncherActionImpl(QObject *parent, \
AbstractGroupableItem *item, GroupManager *strategy)</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">352</font></th>  <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">            <span \
class="n">setText</span><span class="p">(</span><span class="n">i18n</span><span \
class="p">(</span><span class="s">&quot;&amp;Show A Launcher <span class="hl">For %1 \
</span>When<span class="hl"> It Is</span> Not Running&quot;</span><span \
class="p"><span class="hl">,</span></span><span class="hl"> </span><span \
class="n"><span class="hl">m_name</span></span><span class="p">));</span></pre></td>  \
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">381</font></th>  <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">            \
<span class="n">setText</span><span class="p">(</span><span \
class="n">i18n</span><span class="p">(</span><span class="s">&quot;&amp;Show A \
Launcher When Not Running&quot;</span><span class="p">));</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">we have a \
name, it should be used. it hardly matters what the eventual Launcher is called. \
shortening it with the removal of &quot;It Is&quot; is probably alright \
(&quot;computer application english&quot; :)</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/103004/diff/1/?file=39919#file39919line415" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libs/taskmanager/taskactions.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">NewInstanceActionImpl::NewInstanceActionImpl(QObject *parent, \
AbstractGroupableItem *item)</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">412</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="n">NewInstanceActionImpl</span><span class="o">::</span><span \
class="n">NewInstanceActionImpl</span><span class="p">(</span><span \
class="n">QObject</span> <span class="o">*</span><span class="n">parent</span><span \
class="p">,</span> <span class="n">AbstractGroupableItem</span> <span \
class="o">*</span><span class="n">item</span><span class="p">)</span></pre></td>  \
</tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">how well \
does this work with KUniqueApplications?</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/103004/diff/1/?file=39919#file39919line418" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libs/taskmanager/taskactions.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">NewInstanceActionImpl::NewInstanceActionImpl(QObject *parent, \
AbstractGroupableItem *item)</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">415</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="k">if</span> <span class="p">(</span><span \
class="n">LauncherItemType</span><span class="o">==</span><span \
class="n">item</span><span class="o">-&gt;</span><span class="n">itemType</span><span \
class="p">())</span> <span class="p">{</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">whitespace \
around ==</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/103004/diff/1/?file=39919#file39919line420" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libs/taskmanager/taskactions.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">NewInstanceActionImpl::NewInstanceActionImpl(QObject *parent, \
AbstractGroupableItem *item)</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">417</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="p">}</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">418</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="k">else</span> <span class="p">{</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">should be \
on same line</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/103004/diff/1/?file=39919#file39919line496" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libs/taskmanager/taskactions.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">EditGroupActionImpl::EditGroupActionImpl(QObject *parent, TaskGroup *group, \
GroupManager *groupManager)</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">493</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="k">if</span><span class="p">(</span><span class="o">!</span><span \
class="n">simple</span><span class="p">)</span> <span class="p">{</span></pre></td>  \
</tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ws</pre> \
</div> <br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/103004/diff/1/?file=39919#file39919line502" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libs/taskmanager/taskactions.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">EditGroupActionImpl::EditGroupActionImpl(QObject *parent, TaskGroup *group, \
GroupManager *groupManager)</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">499</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="k">if</span><span class="p">(</span><span class="o">!</span><span \
class="n">simple</span><span class="p">)</span> <span class="p">{</span></pre></td>  \
</tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ws</pre> \
</div> <br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/103004/diff/1/?file=39919#file39919line508" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libs/taskmanager/taskactions.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">EditGroupActionImpl::EditGroupActionImpl(QObject *parent, TaskGroup *group, \
GroupManager *groupManager)</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">505</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="k">if</span><span class="p">(</span><span class="o">!</span><span \
class="n">simple</span><span class="p">)</span> <span class="p">{</span></pre></td>  \
</tr>

 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">440</font></th>  <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="n">addMenu</span><span class="p">(</span><span class="k">new</span> <span \
class="n">AdvancedMenu</span><span class="p">(</span><span class="k">this</span><span \
class="p">,</span> <span class="n">item</span><span class="p">,</span> <span \
class="n">strategy</span><span class="p">));</span></pre></td>  <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">506</font></th>  <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="n">addMenu</span><span class="p">(</span><span class="k">new</span> <span \
class="n">AdvancedMenu</span><span class="p">(</span><span class="k">this</span><span \
class="p">,</span> <span class="n">item</span><span class="p">,</span> <span \
class="n">strategy</span><span class="p">));</span></pre></td>  </tr>

 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">507</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="p">}</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">there&#39;s \
a line between &quot;simplifiying&quot; and &quot;making it useless in too many \
cases&quot; that this crosses imho. this would have me reaching for the window \
titlebar in too many cases.

i would be in favour of renaming &quot;Advanced&quot; (a word we are trying to get \
away from) with something like &quot;More actions&quot;</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/103004/diff/1/?file=39919#file39919line530" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libs/taskmanager/taskactions.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">EditGroupActionImpl::EditGroupActionImpl(QObject *parent, TaskGroup *group, \
GroupManager *groupManager)</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">527</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="k">if</span><span class="p">(</span><span class="o">!</span><span \
class="n">simple</span><span class="p">)</span> <span class="p">{</span></pre></td>  \
</tr>

 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">458</font></th>  <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="n">foreach</span> <span class="p">(</span><span \
class="n">AbstractGroupableItem</span> <span class="o">*</span><span \
class="n">item</span><span class="p">,</span> <span class="n">group</span><span \
class="o">-&gt;</span><span class="n">members</span><span class="p">())</span> <span \
class="p">{</span></pre></td>  <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">528</font></th>  <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; ">        <span class="n">foreach</span> <span \
class="p">(</span><span class="n">AbstractGroupableItem</span> <span \
class="o">*</span><span class="n">item</span><span class="p">,</span> <span \
class="n">group</span><span class="o">-&gt;</span><span class="n">members</span><span \
class="p">())</span> <span class="p">{</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">459</font></th>  <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="k">if</span> <span class="p">(</span><span class="n">item</span><span \
class="o">-&gt;</span><span class="n">itemType</span><span class="p">()</span> <span \
class="o">==</span> <span class="n">GroupItemType</span><span class="p">)</span> \
<span class="p">{</span></pre></td>  <th bgcolor="#f0f0f0" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">529</font></th>  <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; ">            <span class="k">if</span> <span \
class="p">(</span><span class="n">item</span><span class="o">-&gt;</span><span \
class="n">itemType</span><span class="p">()</span> <span class="o">==</span> <span \
class="n">GroupItemType</span><span class="p">)</span> <span \
class="p">{</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">460</font></th>  <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">            <span \
class="n">addMenu</span><span class="p">(</span><span class="k">new</span> <span \
class="n">BasicMenu</span><span class="p">(</span><span class="k">this</span><span \
class="p">,</span> <span class="k">dynamic_cast</span><span \
class="o">&lt;</span><span class="n">TaskGroup</span><span \
class="o">*&gt;</span><span class="p">(</span><span class="n">item</span><span \
class="p">),</span> <span class="n">strategy</span><span \
class="p">));</span></pre></td>  <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">530</font></th>  <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; ">                <span \
class="n">addMenu</span><span class="p">(</span><span class="k">new</span> <span \
class="n">BasicMenu</span><span class="p">(</span><span class="k">this</span><span \
class="p">,</span> <span class="k">dynamic_cast</span><span \
class="o">&lt;</span><span class="n">TaskGroup</span><span \
class="o">*&gt;</span><span class="p">(</span><span class="n">item</span><span \
class="p">),</span> <span class="n">strategy</span><span \
class="p">));</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">461</font></th>  <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="p">}</span> <span class="k">else</span> <span class="p">{</span></pre></td>  \
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">531</font></th>  <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">            \
<span class="p">}</span> <span class="k">else</span> <span \
class="p">{</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">462</font></th>  <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">            <span \
class="n">addMenu</span><span class="p">(</span><span class="k">new</span> <span \
class="n">BasicMenu</span><span class="p">(</span><span class="k">this</span><span \
class="p">,</span> <span class="k">dynamic_cast</span><span \
class="o">&lt;</span><span class="n">TaskItem</span><span class="o">*&gt;</span><span \
class="p">(</span><span class="n">item</span><span class="p">),</span> <span \
class="n">strategy</span><span class="p">));</span></pre></td>  <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">532</font></th>  <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">                <span \
class="n">addMenu</span><span class="p">(</span><span class="k">new</span> <span \
class="n">BasicMenu</span><span class="p">(</span><span class="k">this</span><span \
class="p">,</span> <span class="k">dynamic_cast</span><span \
class="o">&lt;</span><span class="n">TaskItem</span><span class="o">*&gt;</span><span \
class="p">(</span><span class="n">item</span><span class="p">),</span> <span \
class="n">strategy</span><span class="p">));</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">463</font></th>  <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="p">}</span></pre></td>  <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">533</font></th>  <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; ">            <span class="p">}</span></pre></td>  \
</tr>

  <tr>
    <th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">464</font></th>  <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="p">}</span></pre></td>  <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">534</font></th>  <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; ">        <span class="p">}</span></pre></td>  \
</tr>

 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">465</font></th>  <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2"></font></th>  <td bgcolor="#ffc5ce" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  \
</tr>

 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">466</font></th>  <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="n">addSeparator</span><span class="p">();</span></pre></td>  <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">535</font></th>  <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="n">addSeparator</span><span class="p">();</span></pre></td>  </tr>

 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">536</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="p">}</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">with this \
change one has to open the goup, right click on the correct entry and then choose. i \
don&#39;t see the point of this simlification other than to make it harder to get \
at.</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/103004/diff/1/?file=39919#file39919line543" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libs/taskmanager/taskactions.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">EditGroupActionImpl::EditGroupActionImpl(QObject *parent, TaskGroup *group, \
GroupManager *groupManager)</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">468</font></th>  <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span class="k">if</span> \
<span class="p">(</span><span class="n">TaskManager</span><span \
class="o">::</span><span class="n">self</span><span class="p">()</span><span \
class="o">-&gt;</span><span class="n">numberOfDesktops</span><span \
class="p">()</span> <span class="o">&gt;</span> <span class="mi">1</span><span \
class="p">)</span> <span class="p">{</span></pre></td>  <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">539</font></th>  <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span class="k">if</span> \
<span class="p">(</span><span class="o"><span class="hl">!</span></span><span \
class="n"><span class="hl">simple</span></span><span class="hl"> </span><span \
class="o"><span class="hl">&amp;&amp;</span></span><span class="hl"> </span><span \
class="n">TaskManager</span><span class="o">::</span><span class="n">self</span><span \
class="p">()</span><span class="o">-&gt;</span><span \
class="n">numberOfDesktops</span><span class="p">()</span> <span \
class="o">&gt;</span> <span class="mi">1</span><span class="p">)</span> <span \
class="p">{</span></pre></td>  </tr>

 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">469</font></th>  <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="n">addMenu</span><span class="p">(</span><span class="k">new</span> <span \
class="n">DesktopsMenu</span><span class="p">(</span><span class="k">this</span><span \
class="p">,</span> <span class="n">group</span><span class="p">));</span></pre></td>  \
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">540</font></th>  <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="n">addMenu</span><span class="p">(</span><span class="k">new</span> <span \
class="n">DesktopsMenu</span><span class="p">(</span><span class="k">this</span><span \
class="p">,</span> <span class="n">group</span><span class="p">));</span></pre></td>  \
</tr>

  <tr>
    <th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">470</font></th>  <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="n">addAction</span><span class="p">(</span><span class="k">new</span> <span \
class="n">ToCurrentDesktopActionImpl</span><span class="p">(</span><span \
class="k">this</span><span class="p">,</span> <span class="n">group</span><span \
class="p">));</span></pre></td>  <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">541</font></th>  <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; ">        <span class="n">addAction</span><span \
class="p">(</span><span class="k">new</span> <span \
class="n">ToCurrentDesktopActionImpl</span><span class="p">(</span><span \
class="k">this</span><span class="p">,</span> <span class="n">group</span><span \
class="p">));</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">471</font></th>  <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="p">}</span></pre></td>  <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">542</font></th>  <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; ">    <span class="p">}</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">no, this is \
one of the PRIMARY uses of the context menu. what would be nice is to move &quot;To \
Current Desktop&quot; into the DesktopsMenu, however, right above &quot;All \
Desktops&quot;</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/103004/diff/1/?file=39919#file39919line550" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libs/taskmanager/taskactions.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">EditGroupActionImpl::EditGroupActionImpl(QObject *parent, TaskGroup *group, \
GroupManager *groupManager)</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">546</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="k">if</span><span class="p">(</span><span class="o">!</span><span \
class="n">simple</span><span class="p">)</span> <span class="p">{</span></pre></td>  \
</tr>

 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">475</font></th>  <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="n">addAction</span><span class="p">(</span><span class="k">new</span> <span \
class="n">ShadeActionImpl</span><span class="p">(</span><span \
class="k">this</span><span class="p">,</span> <span class="n">group</span><span \
class="p">));</span></pre></td>  <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">547</font></th>  <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; ">        <span class="n">addAction</span><span \
class="p">(</span><span class="k">new</span> <span \
class="n">ShadeActionImpl</span><span class="p">(</span><span \
class="k">this</span><span class="p">,</span> <span class="n">group</span><span \
class="p">));</span></pre></td>  </tr>

 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">548</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="p">}</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">could be \
moved into the &quot;Advanced&quot;(/&quot;More Actions&quot;) menu?</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/103004/diff/1/?file=39919#file39919line556" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libs/taskmanager/taskactions.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">EditGroupActionImpl::EditGroupActionImpl(QObject *parent, TaskGroup *group, \
GroupManager *groupManager)</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">552</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="k">if</span><span class="p">(</span><span class="o">!</span><span \
class="n">simple</span><span class="p">)</span> <span class="p">{</span></pre></td>  \
</tr>

 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">477</font></th>  <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="n">addMenu</span><span class="p">(</span><span class="k">new</span> <span \
class="n">AdvancedMenu</span><span class="p">(</span><span class="k">this</span><span \
class="p">,</span> <span class="n">group</span><span class="p">,</span> <span \
class="n">strategy</span><span class="p">));</span></pre></td>  <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">553</font></th>  <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="n">addMenu</span><span class="p">(</span><span class="k">new</span> <span \
class="n">AdvancedMenu</span><span class="p">(</span><span class="k">this</span><span \
class="p">,</span> <span class="n">group</span><span class="p">,</span> <span \
class="n">strategy</span><span class="p">));</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">478</font></th>  <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="n">addAction</span><span class="p">(</span><span class="k">new</span> <span \
class="n">EditGroupActionImpl</span><span class="p">(</span><span \
class="k">this</span><span class="p">,</span> <span class="n">group</span><span \
class="p">,</span> <span class="n">strategy</span><span \
class="p">));</span></pre></td>  <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">554</font></th>  <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; ">        <span class="n">addAction</span><span \
class="p">(</span><span class="k">new</span> <span \
class="n">EditGroupActionImpl</span><span class="p">(</span><span \
class="k">this</span><span class="p">,</span> <span class="n">group</span><span \
class="p">,</span> <span class="n">strategy</span><span \
class="p">));</span></pre></td>  </tr>

 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">555</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="p">}</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">again, this \
is just crippling the menu, not making it &quot;simpler&quot;</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/103004/diff/1/?file=39919#file39919line597" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libs/taskmanager/taskactions.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">void BasicMenu::addAppActions(QList &lt;QAction*&gt; &amp;appActions)</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">592</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">            \
<span class="k">if</span><span class="p">(</span><span class="n">action</span><span \
class="o">-&gt;</span><span class="n">isSeparator</span><span class="p">())</span> \
<span class="p">{</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">593</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">              \
<span class="n">addSeparator</span><span class="p">();</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">594</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">            \
<span class="p">}</span> <span class="k">else</span> <span \
class="p">{</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">you should \
be able to just  menu-&gt;addAction(action) for the separator case?</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/103004/diff/1/?file=39919#file39919line600" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libs/taskmanager/taskactions.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">void BasicMenu::addAppActions(QList &lt;QAction*&gt; &amp;appActions)</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">595</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">              \
<span class="n">QString</span> <span class="n">title</span><span \
class="o">=</span><span class="n">action</span><span class="o">-&gt;</span><span \
class="n">property</span><span class="p">(</span><span \
class="s">&quot;action-group-name&quot;</span><span class="p">).</span><span \
class="n">toString</span><span class="p">();</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this is a \
misuse of QAction. you can add QActions to a QAction and that parent QAction becomes \
the submenu. no need for such custom property setting/reading and menu \
creation.</pre> </div>
<br />

<p>- Aaron J.</p>

<br />
<p>On October 31st, 2011, 8:40 p.m., Craig Drummond wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Craig Drummond.</div>

<p style="color: grey;"><i>Updated Oct. 31, 2011, 8:40 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">1. Add NewInstance action to launch a new instance of an application. 2. \
Move toggle launcher action out of advanced menu. 3. Don&#39;t show application name \
in &#39;Show A Launcher&#39; action, as might not know the real name at this time \
(e.g. no desktop file read). 4. Add application actions, to be shown at the top of \
the right-click menu. IconTasks uses this to show recent docuents, dock manager menu \
items, and unity items. 5. A ToolTipMenu class is created, so that tooltips may be \
give for menu items. This is so that IconTasks can display the full path of a \
documents in the recent documents menu. 6. Add option to have only basic window \
controls in menu. </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>libs/taskmanager/taskactions.h <span style="color: grey">(2b5a641)</span></li>

 <li>libs/taskmanager/taskactions.cpp <span style="color: grey">(0e6ba8e)</span></li>

 <li>libs/taskmanager/taskactions_p.h <span style="color: grey">(913966c)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103004/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 