'Review Request: TaskManager: TaskAction changes from IconTasks'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request: TaskManager: TaskAction changes from IconTasks
From:       "Craig Drummond" <craig () kde ! org>
Date:       2011-10-31 20:40:43
Message-ID: 20111031204043.31621.14136 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103004/
-----------------------------------------------------------

Review request for Plasma.

Description
-------

1. Add NewInstance action to launch a new instance of an application.
2. Move toggle launcher action out of advanced menu.
3. Don't show application name in 'Show A Launcher' action, as might not kn=
ow the real name at this time (e.g. no desktop file read).
4. Add application actions, to be shown at the top of the right-click menu.=
 IconTasks uses this to show recent docuents, dock manager menu items, and =
unity items.
5. A ToolTipMenu class is created, so that tooltips may be give for menu it=
ems. This is so that IconTasks can display the full path of a documents in =
the recent documents menu.
6. Add option to have only basic window controls in menu.

Diffs
-----

  libs/taskmanager/taskactions.h 2b5a641 =

  libs/taskmanager/taskactions.cpp 0e6ba8e =

  libs/taskmanager/taskactions_p.h 913966c =

Diff: http://git.reviewboard.kde.org/r/103004/diff/diff

Testing
-------

Thanks,

Craig Drummond

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103004/">http://git.reviewboard.kde.org/r/103004/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Craig Drummond.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">1. Add NewInstance action to launch a new instance of an application. 2. \
Move toggle launcher action out of advanced menu. 3. Don&#39;t show application name \
in &#39;Show A Launcher&#39; action, as might not know the real name at this time \
(e.g. no desktop file read). 4. Add application actions, to be shown at the top of \
the right-click menu. IconTasks uses this to show recent docuents, dock manager menu \
items, and unity items. 5. A ToolTipMenu class is created, so that tooltips may be \
give for menu items. This is so that IconTasks can display the full path of a \
documents in the recent documents menu. 6. Add option to have only basic window \
controls in menu. </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>libs/taskmanager/taskactions.h <span style="color: grey">(2b5a641)</span></li>

 <li>libs/taskmanager/taskactions.cpp <span style="color: grey">(0e6ba8e)</span></li>

 <li>libs/taskmanager/taskactions_p.h <span style="color: grey">(913966c)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103004/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 