'Review Request: TaskManager: Prompt user when automatic task to'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request: TaskManager: Prompt user when automatic task to
From:       "Craig Drummond" <craig () kde ! org>
Date:       2011-10-31 20:42:42
Message-ID: 20111031204242.31663.47079 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103007/
-----------------------------------------------------------

Review request for Plasma.

Description
-------

1. If fail to automatically find launcher, then prompt user to select from =
installed applications.
2. Add a config page, so that manualy set launchers may be adjusted.

(Part of IconTasks' taskmanager changes)

Diffs
-----

  libs/taskmanager/CMakeLists.txt 57f5f73 =

  libs/taskmanager/groupmanager.h acaa142 =

  libs/taskmanager/groupmanager.cpp 6e7ffa7 =

  libs/taskmanager/kapplicationselectordialog.h PRE-CREATION =

  libs/taskmanager/kapplicationselectordialog.cpp PRE-CREATION =

  libs/taskmanager/launcherconfig.h PRE-CREATION =

  libs/taskmanager/launcherconfig.cpp PRE-CREATION =

  libs/taskmanager/launcherconfig.ui PRE-CREATION =

  libs/taskmanager/launcherproperties.h PRE-CREATION =

  libs/taskmanager/launcherproperties.cpp PRE-CREATION =

  libs/taskmanager/launcherproperties.ui PRE-CREATION =

  libs/taskmanager/taskactions.cpp 0e6ba8e =

  libs/taskmanager/taskitem.h 5de8478 =

  libs/taskmanager/taskitem.cpp 0a768e5 =

Diff: http://git.reviewboard.kde.org/r/103007/diff/diff

Testing
-------

Thanks,

Craig Drummond

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103007/">http://git.reviewboard.kde.org/r/103007/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Craig Drummond.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">1. If fail to automatically find launcher, then prompt user to select \
from installed applications. 2. Add a config page, so that manualy set launchers may \
be adjusted.

(Part of IconTasks&#39; taskmanager changes)</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>libs/taskmanager/CMakeLists.txt <span style="color: grey">(57f5f73)</span></li>

 <li>libs/taskmanager/groupmanager.h <span style="color: grey">(acaa142)</span></li>

 <li>libs/taskmanager/groupmanager.cpp <span style="color: \
grey">(6e7ffa7)</span></li>

 <li>libs/taskmanager/kapplicationselectordialog.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>libs/taskmanager/kapplicationselectordialog.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>libs/taskmanager/launcherconfig.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>libs/taskmanager/launcherconfig.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>libs/taskmanager/launcherconfig.ui <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>libs/taskmanager/launcherproperties.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>libs/taskmanager/launcherproperties.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>libs/taskmanager/launcherproperties.ui <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>libs/taskmanager/taskactions.cpp <span style="color: grey">(0e6ba8e)</span></li>

 <li>libs/taskmanager/taskitem.h <span style="color: grey">(5de8478)</span></li>

 <li>libs/taskmanager/taskitem.cpp <span style="color: grey">(0a768e5)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103007/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 