'Review Request: TaskManager: Store launcher order'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request: TaskManager: Store launcher order
From:       "Craig Drummond" <craig () kde ! org>
Date:       2011-10-31 20:42:19
Message-ID: 20111031204219.31663.8397 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103006/
-----------------------------------------------------------

Review request for Plasma.

Description
-------

1. Store the order in which launchers are created
2. Add a new config option, separateLaunchers - so that applet can decide i=
f launchers and tasks should be kept separate.

(Part of IconTasks' taskmanager changes)

Diffs
-----

  libs/taskmanager/abstractgroupingstrategy.cpp 4ed424a =

  libs/taskmanager/abstractsortingstrategy.cpp 390f6f0 =

  libs/taskmanager/groupmanager.h acaa142 =

  libs/taskmanager/groupmanager.cpp 6e7ffa7 =

  libs/taskmanager/launcheritem.cpp 20f0e7c =

  libs/taskmanager/strategies/alphasortingstrategy.cpp 9ec1aca =

  libs/taskmanager/strategies/desktopsortingstrategy.cpp 520fead =

  libs/taskmanager/strategies/manualsortingstrategy.h 113faab =

  libs/taskmanager/strategies/manualsortingstrategy.cpp 4409a6b =

  libs/taskmanager/strategies/programgroupingstrategy.cpp 5c43d03 =

  libs/taskmanager/taskgroup.h 53c2871 =

  libs/taskmanager/taskgroup.cpp 49140ae =

  libs/taskmanager/taskitem.h 5de8478 =

  libs/taskmanager/taskitem.cpp 0a768e5 =

Diff: http://git.reviewboard.kde.org/r/103006/diff/diff

Testing
-------

Thanks,

Craig Drummond

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103006/">http://git.reviewboard.kde.org/r/103006/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Craig Drummond.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">1. Store the order in which launchers are created 2. Add a new config \
option, separateLaunchers - so that applet can decide if launchers and tasks should \
be kept separate.

(Part of IconTasks&#39; taskmanager changes)</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>libs/taskmanager/abstractgroupingstrategy.cpp <span style="color: \
grey">(4ed424a)</span></li>

 <li>libs/taskmanager/abstractsortingstrategy.cpp <span style="color: \
grey">(390f6f0)</span></li>

 <li>libs/taskmanager/groupmanager.h <span style="color: grey">(acaa142)</span></li>

 <li>libs/taskmanager/groupmanager.cpp <span style="color: \
grey">(6e7ffa7)</span></li>

 <li>libs/taskmanager/launcheritem.cpp <span style="color: \
grey">(20f0e7c)</span></li>

 <li>libs/taskmanager/strategies/alphasortingstrategy.cpp <span style="color: \
grey">(9ec1aca)</span></li>

 <li>libs/taskmanager/strategies/desktopsortingstrategy.cpp <span style="color: \
grey">(520fead)</span></li>

 <li>libs/taskmanager/strategies/manualsortingstrategy.h <span style="color: \
grey">(113faab)</span></li>

 <li>libs/taskmanager/strategies/manualsortingstrategy.cpp <span style="color: \
grey">(4409a6b)</span></li>

 <li>libs/taskmanager/strategies/programgroupingstrategy.cpp <span style="color: \
grey">(5c43d03)</span></li>

 <li>libs/taskmanager/taskgroup.h <span style="color: grey">(53c2871)</span></li>

 <li>libs/taskmanager/taskgroup.cpp <span style="color: grey">(49140ae)</span></li>

 <li>libs/taskmanager/taskitem.h <span style="color: grey">(5de8478)</span></li>

 <li>libs/taskmanager/taskitem.cpp <span style="color: grey">(0a768e5)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103006/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 