[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Make the task manager items move in realtime when
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2011-10-25 13:18:12
Message-ID: 20111025131812.15438.84037 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Oct. 25, 2011, 12:48 p.m., Aaron J. Seigo wrote:
> > plasma/desktop/applets/tasks/taskgroupitem.cpp, lines 1037-1038
> > <http://git.reviewboard.kde.org/r/102833/diff/1/?file=38602#file38602line1037>
> >
> > i wonder what happens here when you drag an entry from one tasks widget to \
> > another? :)
>
> Shantanu Tushar Jha wrote:
> Well in that case the corresponding entry moves even in the other tasks widget, \
> which is the same behavior as earlier. I'm not sure if thats a problem, is it?
probably, as that's how it was before. just something i noticed while reviewing. \
shouldn't hold this patch up at all, though.
- Aaron J.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102833/#review7601
-----------------------------------------------------------
On Oct. 11, 2011, 6:19 p.m., Shantanu Tushar Jha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102833/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2011, 6:19 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> Right now, if the user sets the Task Manager sorting to "manually", its possible to \
> arrange the task items manually. However, the items move only after the mouse \
> button is released. This patch makes the items move dynamically and follow the \
> mouse, this helps to produce a more natural effect. Check the attached video for a \
> demo.
>
> Diffs
> -----
>
> plasma/desktop/applets/tasks/taskgroupitem.h 7ca95ef
> plasma/desktop/applets/tasks/taskgroupitem.cpp 14053d6
>
> Diff: http://git.reviewboard.kde.org/r/102833/diff/diff
>
>
> Testing
> -------
>
> Works perfectly in both horizontal and vertical configurations, and multiple rows. \
> I didn't find any side-effects.
>
> Thanks,
>
> Shantanu Tushar Jha
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102833/">http://git.reviewboard.kde.org/r/102833/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 25th, 2011, 12:48 p.m., <b>Aaron J. \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/102833/diff/1/?file=38602#file38602line1037" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/desktop/applets/tasks/taskgroupitem.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">void TaskGroupItem::dragMoveEvent(QGraphicsSceneDragDropEvent* event)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1037</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span class="n">event</span><span \
class="o">-></span><span class="n">mimeData</span><span class="p">()</span><span \
class="o">-></span><span class="n">hasFormat</span><span class="p">(</span><span \
class="n">TaskManager</span><span class="o">::</span><span class="n">Task</span><span \
class="o">::</span><span class="n">mimetype</span><span class="p">())</span> <span \
class="o">||</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1038</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">event</span><span class="o">-></span><span \
class="n">mimeData</span><span class="p">()</span><span class="o">-></span><span \
class="n">hasFormat</span><span class="p">(</span><span \
class="n">TaskManager</span><span class="o">::</span><span class="n">Task</span><span \
class="o">::</span><span class="n">groupMimetype</span><span class="p">()))</span> \
<span class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i wonder what happens \
here when you drag an entry from one tasks widget to another? :)</pre> </blockquote>
<p>On October 25th, 2011, 1:15 p.m., <b>Shantanu Tushar Jha</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well in that case the \
corresponding entry moves even in the other tasks widget, which is the same behavior \
as earlier. I'm not sure if thats a problem, is it?</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">probably, \
as that's how it was before. just something i noticed while reviewing. \
shouldn't hold this patch up at all, though.</pre> <br />
<p>- Aaron J.</p>
<br />
<p>On October 11th, 2011, 6:19 p.m., Shantanu Tushar Jha wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Shantanu Tushar Jha.</div>
<p style="color: grey;"><i>Updated Oct. 11, 2011, 6:19 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Right now, if the user sets the Task Manager sorting to \
"manually", its possible to arrange the task items manually. However, the \
items move only after the mouse button is released. This patch makes the items move \
dynamically and follow the mouse, this helps to produce a more natural effect. Check \
the attached video for a demo.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works perfectly in both horizontal and vertical configurations, and \
multiple rows. I didn't find any side-effects.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/desktop/applets/tasks/taskgroupitem.h <span style="color: \
grey">(7ca95ef)</span></li>
<li>plasma/desktop/applets/tasks/taskgroupitem.cpp <span style="color: \
grey">(14053d6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102833/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic