--===============8539405362297408995== Content-Type: multipart/alternative; boundary="===============4298883787073959410==" --===============4298883787073959410== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Oct. 25, 2011, 12:48 p.m., Aaron J. Seigo wrote: > > plasma/desktop/applets/tasks/taskgroupitem.cpp, lines 1037-1038 > > > > > > i wonder what happens here when you drag an entry from one tasks wi= dget to another? :) > = > Shantanu Tushar Jha wrote: > Well in that case the corresponding entry moves even in the other tas= ks widget, which is the same behavior as earlier. I'm not sure if thats a p= roblem, is it? probably, as that's how it was before. just something i noticed while revie= wing. shouldn't hold this patch up at all, though. - Aaron J. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102833/#review7601 ----------------------------------------------------------- On Oct. 11, 2011, 6:19 p.m., Shantanu Tushar Jha wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102833/ > ----------------------------------------------------------- > = > (Updated Oct. 11, 2011, 6:19 p.m.) > = > = > Review request for Plasma. > = > = > Description > ------- > = > Right now, if the user sets the Task Manager sorting to "manually", its p= ossible to arrange the task items manually. However, the items move only af= ter the mouse button is released. > This patch makes the items move dynamically and follow the mouse, this he= lps to produce a more natural effect. Check the attached video for a demo. > = > = > Diffs > ----- > = > plasma/desktop/applets/tasks/taskgroupitem.h 7ca95ef = > plasma/desktop/applets/tasks/taskgroupitem.cpp 14053d6 = > = > Diff: http://git.reviewboard.kde.org/r/102833/diff/diff > = > = > Testing > ------- > = > Works perfectly in both horizontal and vertical configurations, and multi= ple rows. I didn't find any side-effects. > = > = > Thanks, > = > Shantanu Tushar Jha > = > --===============4298883787073959410== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/102833/

On October 25th, 2011, 12:48 p.m., Aaron J.= Seigo wrote:

= = =
plasma/desktop/applets/tasks/taskgroupitem.cpp (Diff revision 1) 

   
void TaskGroupItem::dragMoveEvent(QGraphicsSceneDragDropEvent* even=
t)


  

 

  

    
    

    1037
    
    if (event->mimeData()=
->hasFormat(TaskManager::Task::mimetype<=
span class=3D"p">()) ||

  


  

    
    

    1038
    
        event->mimeData()=
->hasFormat(TaskManager::Task::groupMimetype())) {

  


 




  
i wonder =
what happens here when you drag an entry from one tasks widget to another? =
:)

 




 
On October 25th, 2011, 1:15 p.m., Shantanu Tushar Jha wrote:

 

  
Well in t=
hat case the corresponding entry moves even in the other tasks widget, whic=
h is the same behavior as earlier. I'm not sure if thats a problem, is =
it?

 











probably, as that's how it was before. just something i noticed =
while reviewing. shouldn't hold this patch up at all, though.








- Aaron J.






On October 11th, 2011, 6:19 p.m., Shantanu Tushar Jha wrote:









 

  


Review request for Plasma.


By Shantanu Tushar Jha.




Updated Oct. 11, 2011, 6:19 p.m.








Descripti=
on 

 

 

  
   
Right now, if the user sets the Task Manager sorting to &quo=
t;manually", its possible to arrange the task items manually. However,=
 the items move only after the mouse button is released.
This patch makes the items move dynamically and follow the mouse, this help=
s to produce a more natural effect. Check the attached video for a demo.
  

 






Testing <=
/h1>


 

  
   
Works perfectly in both horizontal and vertical configuratio=
ns, and multiple rows. I didn't find any side-effects.

  		
 








Diffs=
 


    

 
  • plasma/desktop/applets/tasks/taskgroupitem.h (7ca95ef)
    • 

 
  • plasma/desktop/applets/tasks/taskgroupitem.cpp (14053d6)
    • 





View Diff





  		
 











  

 



--===============4298883787073959410==--

--===============8539405362297408995==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

--===============8539405362297408995==--