--===============1056926538381884160== Content-Type: multipart/alternative; boundary="===============8416353840489952678==" --===============8416353840489952678== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102944/#review7603 ----------------------------------------------------------- Ship it! Ship It! - Aaron J. Seigo On Oct. 23, 2011, 1:11 a.m., David Edmundson wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102944/ > ----------------------------------------------------------- > = > (Updated Oct. 23, 2011, 1:11 a.m.) > = > = > Review request for Plasma. > = > = > Description > ------- > = > A rewrite of https://git.reviewboard.kde.org/r/102878/ fixes suffixes by = rewriting it into "every 2 minutes" rather than "every 2th (or 2nd) minutes= " which is far more translatable. > = > Also restricts input to a smaller range of sane values. It makes /no/ sen= se to have something that isn't a factor of 60, as otherwise you get a long= er gap between intervals when the hour comes round. This makes it easier fo= r a user to select something sensible. Allowing these as inputs is wrong. A= s an additional bonus it now reads "Every hour" rather than "60 minutes" wh= ich is more intuitive. > = > = > Diffs > ----- > = > libs/plasmaclock/clockapplet.cpp 4f16cb1 = > libs/plasmaclock/generalConfig.ui aae25c0 = > = > Diff: http://git.reviewboard.kde.org/r/102944/diff/diff > = > = > Testing > ------- > = > Tested that it loads saves correctly. Also tried loading from a config fi= le which had a value not in my combo box. This is an incredibly unlikely se= tup (which is why I'm changing it). It simply reverts back to being set to = "Never" the first time they open the config, allowing them to set something= else. > = > = > Screenshots > ----------- > = > = > http://git.reviewboard.kde.org/r/102944/s/314/ > = > = > Thanks, > = > David Edmundson > = > --===============8416353840489952678== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/102944/

Ship it!

Ship It!

- Aaron J.

On October 23rd, 2011, 1:11 a.m., David Edmundson wrote:

Review request for Plasma.

By David Edmundson.

Updated Oct. 23, 2011, 1:11 a.m.

Descripti= on

A rewrite of https://git.reviewboard.kde.org/r/102878/ fixes=
 suffixes by rewriting it into "every 2 minutes" rather than &quo=
t;every 2th (or 2nd) minutes" which is far more translatable.

Also restricts input to a smaller range of sane values. It makes /no/ sense=
 to have something that isn't a factor of 60, as otherwise you get a lo=
nger gap between intervals when the hour comes round. This makes it easier =
for a user to select something sensible. Allowing these as inputs is wrong.=
 As an additional bonus it now reads "Every hour" rather than &qu=
ot;60 minutes" which is more intuitive.

Testing <= /h1>

Tested that it loads saves correctly. Also tried loading fro=
m a config file which had a value not in my combo box. This is an incredibl=
y unlikely setup (which is why I'm changing it). It simply reverts back=
 to being set to "Never" the first time they open the config, all=
owing them to set something else.

Diffs=

libs/plasmaclock/clockapplet.cpp (4f16cb1)=
libs/plasmaclock/generalConfig.ui (aae25c0= )

Screensho= ts

3D""

--===============8416353840489952678==-- --===============1056926538381884160== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============1056926538381884160==--