[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Add option to not show popup when devices are
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2011-10-25 12:44:08
Message-ID: 20111025124408.12506.1105 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


> On Oct. 18, 2011, 2:47 p.m., Jacopo De Simoi wrote:
> > I am not sure if I actually would allow to block the device notifier fr=
om popping up altogheter; =

> > If a user doesn't want the notifier to popup for a specific device she =
can simply hide it by right-clicking on the device item.
> =

> Aaron J. Seigo wrote:
>     agreed; it's an option for a very specific use pattern (in particular=
: the "i always have the file manager already open already" user) which i d=
on't see as often as the "i have nothing on my screen" or "i have everythin=
g but a view on that one device" while watching people use their systems. f=
or most people this would just mean more clicking; for many of the rest it'=
s a confirmation the device is ready and is otherwise ignorable. adding an =
option in the UI and the code for the remaining fraction is not worthwhile =
given the cost in terms of configuration UI, user support and code maintane=
nce.

ah, something i forgot to add: thank you for the patch! :) while not every =
patch is accepted, they are always appreciated and are often a great way to=
 communicate ideas.


- Aaron J.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102825/#review7464
-----------------------------------------------------------


On Oct. 11, 2011, 1:30 p.m., Simon Persson wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102825/
> -----------------------------------------------------------
> =

> (Updated Oct. 11, 2011, 1:30 p.m.)
> =

> =

> Review request for Plasma, Giulio Camuffo and Jacopo De Simoi.
> =

> =

> Description
> -------
> =

> Use case:
> User 1 frequently connects her phone to her laptop to charge the battery,=
 she has no intention of accessing files on the phone and thinks the device=
 notifier popping up (even for a few seconds) is distracting. When accessin=
g files on an external drive she usually uses an already running instance o=
f her file manager and again would prefer the notifier to not pop up. She k=
eeps the notifier in her panel for the case of easily watching dvd's and do=
wnloading photos from a camera memory card. In those cases she thinks it's =
enough that the icon appears with an exclamation mark in her systray, she c=
an find it there.
> =

> =

> Diffs
> -----
> =

>   plasma/generic/applets/devicenotifier/configurationpage.ui a916254 =

>   plasma/generic/applets/devicenotifier/devicenotifier.h 9f3af73 =

>   plasma/generic/applets/devicenotifier/devicenotifier.cpp b9dfce5 =

> =

> Diff: http://git.reviewboard.kde.org/r/102825/diff/diff
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Simon Persson
> =

>


[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102825/">http://git.reviewboard.kde.org/r/102825/</a>
  </td>
    </tr>
   </table>
   <br />





<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On October 18th, 2011, 2:47 p.m., <b>Jacopo De \
Simoi</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I am not sure if I actually would allow to block the device notifier \
from popping up altogheter;  If a user doesn&#39;t want the notifier to popup for a \
specific device she can simply hide it by right-clicking on the device item.</pre>  \
</blockquote>




 <p>On October 25th, 2011, 12:43 p.m., <b>Aaron J. Seigo</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">agreed; it&#39;s an \
option for a very specific use pattern (in particular: the &quot;i always have the \
file manager already open already&quot; user) which i don&#39;t see as often as the \
&quot;i have nothing on my screen&quot; or &quot;i have everything but a view on that \
one device&quot; while watching people use their systems. for most people this would \
just mean more clicking; for many of the rest it&#39;s a confirmation the device is \
ready and is otherwise ignorable. adding an option in the UI and the code for the \
remaining fraction is not worthwhile given the cost in terms of configuration UI, \
user support and code maintanence.</pre>  </blockquote>








</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ah, something i forgot \
to add: thank you for the patch! :) while not every patch is accepted, they are \
always appreciated and are often a great way to communicate ideas.</pre> <br />








<p>- Aaron J.</p>


<br />
<p>On October 11th, 2011, 1:30 p.m., Simon Persson wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma, Giulio Camuffo and Jacopo De Simoi.</div>
<div>By Simon Persson.</div>


<p style="color: grey;"><i>Updated Oct. 11, 2011, 1:30 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use case: User 1 frequently connects her phone to her laptop to charge \
the battery, she has no intention of accessing files on the phone and thinks the \
device notifier popping up (even for a few seconds) is distracting. When accessing \
files on an external drive she usually uses an already running instance of her file \
manager and again would prefer the notifier to not pop up. She keeps the notifier in \
her panel for the case of easily watching dvd&#39;s and downloading photos from a \
camera memory card. In those cases she thinks it&#39;s enough that the icon appears \
with an exclamation mark in her systray, she can find it there.</pre>  </td>
 </tr>
</table>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/generic/applets/devicenotifier/configurationpage.ui <span style="color: \
grey">(a916254)</span></li>

 <li>plasma/generic/applets/devicenotifier/devicenotifier.h <span style="color: \
grey">(9f3af73)</span></li>

 <li>plasma/generic/applets/devicenotifier/devicenotifier.cpp <span style="color: \
grey">(b9dfce5)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102825/diff/" style="margin-left: \
3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>



_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic