From kde-panel-devel Tue Oct 25 12:44:08 2011 From: "Aaron J. Seigo" Date: Tue, 25 Oct 2011 12:44:08 +0000 To: kde-panel-devel Subject: Re: Review Request: Add option to not show popup when devices are Message-Id: <20111025124408.12506.1105 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=131954669431064 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1571145393057577716==" --===============1571145393057577716== Content-Type: multipart/alternative; boundary="===============3467133293521582546==" --===============3467133293521582546== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Oct. 18, 2011, 2:47 p.m., Jacopo De Simoi wrote: > > I am not sure if I actually would allow to block the device notifier fr= om popping up altogheter; = > > If a user doesn't want the notifier to popup for a specific device she = can simply hide it by right-clicking on the device item. > = > Aaron J. Seigo wrote: > agreed; it's an option for a very specific use pattern (in particular= : the "i always have the file manager already open already" user) which i d= on't see as often as the "i have nothing on my screen" or "i have everythin= g but a view on that one device" while watching people use their systems. f= or most people this would just mean more clicking; for many of the rest it'= s a confirmation the device is ready and is otherwise ignorable. adding an = option in the UI and the code for the remaining fraction is not worthwhile = given the cost in terms of configuration UI, user support and code maintane= nce. ah, something i forgot to add: thank you for the patch! :) while not every = patch is accepted, they are always appreciated and are often a great way to= communicate ideas. - Aaron J. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102825/#review7464 ----------------------------------------------------------- On Oct. 11, 2011, 1:30 p.m., Simon Persson wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102825/ > ----------------------------------------------------------- > = > (Updated Oct. 11, 2011, 1:30 p.m.) > = > = > Review request for Plasma, Giulio Camuffo and Jacopo De Simoi. > = > = > Description > ------- > = > Use case: > User 1 frequently connects her phone to her laptop to charge the battery,= she has no intention of accessing files on the phone and thinks the device= notifier popping up (even for a few seconds) is distracting. When accessin= g files on an external drive she usually uses an already running instance o= f her file manager and again would prefer the notifier to not pop up. She k= eeps the notifier in her panel for the case of easily watching dvd's and do= wnloading photos from a camera memory card. In those cases she thinks it's = enough that the icon appears with an exclamation mark in her systray, she c= an find it there. > = > = > Diffs > ----- > = > plasma/generic/applets/devicenotifier/configurationpage.ui a916254 = > plasma/generic/applets/devicenotifier/devicenotifier.h 9f3af73 = > plasma/generic/applets/devicenotifier/devicenotifier.cpp b9dfce5 = > = > Diff: http://git.reviewboard.kde.org/r/102825/diff/diff > = > = > Testing > ------- > = > = > Thanks, > = > Simon Persson > = > --===============3467133293521582546== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/102825/

On October 18th, 2011, 2:47 p.m., Jacopo De= Simoi wrote:

I am not =
sure if I actually would allow to block the device notifier from popping up=
 altogheter; =

If a user doesn't want the notifier to popup for a specific device she =
can simply hide it by right-clicking on the device item.

On October 25th, 2011, 12:43 p.m., Aaron J. Seigo wrote:

agreed; i=
t's an option for a very specific use pattern (in particular: the "=
;i always have the file manager already open already" user) which i do=
n't see as often as the "i have nothing on my screen" or &quo=
t;i have everything but a view on that one device" while watching peop=
le use their systems. for most people this would just mean more clicking; f=
or many of the rest it's a confirmation the device is ready and is othe=
rwise ignorable. adding an option in the UI and the code for the remaining =
fraction is not worthwhile given the cost in terms of configuration UI, use=
r support and code maintanence.
ah, somethi=
ng i forgot to add: thank you for the patch! :) while not every patch is ac=
cepted, they are always appreciated and are often a great way to communicat=
e ideas.

- Aaron J.


On October 11th, 2011, 1:30 p.m., Simon Persson wrote:

Review request for Plasma, Giulio Camuffo and Jacopo De Simoi.
By Simon Persson.

Updated Oct. 11, 2011, 1:30 p.m.

Descripti= on 

Use case:
User 1 frequently connects her phone to her laptop to charge the battery, s=
he has no intention of accessing files on the phone and thinks the device n=
otifier popping up (even for a few seconds) is distracting. When accessing =
files on an external drive she usually uses an already running instance of =
her file manager and again would prefer the notifier to not pop up. She kee=
ps the notifier in her panel for the case of easily watching dvd's and =
downloading photos from a camera memory card. In those cases she thinks it&=
#39;s enough that the icon appears with an exclamation mark in her systray,=
 she can find it there.

Diffs=

  • plasma/generic/applets/devicenotifier/configurationpage.ui (a916254)
  • plasma/generic/applets/devicenotifier/devicenotifier.h (9f3af73)
  • plasma/generic/applets/devicenotifier/devicenotifier.cpp (b9dfce5)

View Diff
--===============3467133293521582546==-- --===============1571145393057577716== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============1571145393057577716==--