'Re: Review Request: KMenuEdit: Fix disabling 'Only show in KDE''

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: KMenuEdit: Fix disabling 'Only show in KDE'
From:       "Ralf Jung" <ralfjung-e () gmx ! de>
Date:       2011-09-30 12:39:17
Message-ID: 20110930123917.22291.18174 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On Sept. 30, 2011, 12:32 p.m., Commit Hook wrote:
> > This review has been submitted with commit \
> > 76589567624eadbb2c07ca2578dafa24cb34681a by Aaron Seigo to branch master.

Thank you very much!

- Ralf

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102713/#review6956
-----------------------------------------------------------

On Sept. 26, 2011, 8:01 p.m., Ralf Jung wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102713/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2011, 8:01 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> This fixes the bug that one could not disable the "Only show in KDE" option for an \
> application in KMenuEdit. 
> 
> This addresses bug 190081.
> http://bugs.kde.org/show_bug.cgi?id=190081
> 
> 
> Diffs
> -----
> 
> kmenuedit/basictab.cpp 4612c2a 
> 
> Diff: http://git.reviewboard.kde.org/r/102713/diff/diff
> 
> 
> Testing
> -------
> 
> Compiled and logged in to see that the bug is actually fixed.
> 
> 
> Thanks,
> 
> Ralf Jung
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102713/">http://git.reviewboard.kde.org/r/102713/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On September 30th, 2011, 12:32 p.m., <b>Commit \
Hook</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This review has been submitted with commit \
76589567624eadbb2c07ca2578dafa24cb34681a by Aaron Seigo to branch master.</pre>  \
</blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thank you very \
much!</pre> <br />

<p>- Ralf</p>

<br />
<p>On September 26th, 2011, 8:01 p.m., Ralf Jung wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Ralf Jung.</div>

<p style="color: grey;"><i>Updated Sept. 26, 2011, 8:01 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This fixes the bug that one could not disable the &quot;Only show in \
KDE&quot; option for an application in KMenuEdit.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiled and logged in to see that the bug is actually fixed.</pre>  \
</td>  </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=190081">190081</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kmenuedit/basictab.cpp <span style="color: grey">(4612c2a)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102713/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 