From kde-panel-devel Fri Sep 30 12:39:17 2011 From: "Ralf Jung" Date: Fri, 30 Sep 2011 12:39:17 +0000 To: kde-panel-devel Subject: Re: Review Request: KMenuEdit: Fix disabling 'Only show in KDE' Message-Id: <20110930123917.22291.18174 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=131738638128939 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============6247912198175514508==" --===============6247912198175514508== Content-Type: multipart/alternative; boundary="===============2641633596877438885==" --===============2641633596877438885== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Sept. 30, 2011, 12:32 p.m., Commit Hook wrote: > > This review has been submitted with commit 76589567624eadbb2c07ca2578da= fa24cb34681a by Aaron Seigo to branch master. Thank you very much! - Ralf ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102713/#review6956 ----------------------------------------------------------- On Sept. 26, 2011, 8:01 p.m., Ralf Jung wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102713/ > ----------------------------------------------------------- > = > (Updated Sept. 26, 2011, 8:01 p.m.) > = > = > Review request for Plasma. > = > = > Description > ------- > = > This fixes the bug that one could not disable the "Only show in KDE" opti= on for an application in KMenuEdit. > = > = > This addresses bug 190081. > http://bugs.kde.org/show_bug.cgi?id=3D190081 > = > = > Diffs > ----- > = > kmenuedit/basictab.cpp 4612c2a = > = > Diff: http://git.reviewboard.kde.org/r/102713/diff/diff > = > = > Testing > ------- > = > Compiled and logged in to see that the bug is actually fixed. > = > = > Thanks, > = > Ralf Jung > = > --===============2641633596877438885== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/102713/

On September 30th, 2011, 12:32 p.m., Commit= Hook wrote:

This revi=
ew has been submitted with commit 76589567624eadbb2c07ca2578dafa24cb34681a =
by Aaron Seigo to branch master.
Thank you v=
ery much!

- Ralf


On September 26th, 2011, 8:01 p.m., Ralf Jung wrote:

Review request for Plasma.
By Ralf Jung.

Updated Sept. 26, 2011, 8:01 p.m.

Descripti= on 

This fixes the bug that one could not disable the "Only=
 show in KDE" option for an application in KMenuEdit.

Testing <= /h1> 
Compiled and logged in to see that the bug is actually fixed=
.
Bugs: 190081

Diffs=

  • kmenuedit/basictab.cpp (4612c2a)

View Diff
--===============2641633596877438885==-- --===============6247912198175514508== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============6247912198175514508==--