[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Plasmate: Add mimetype support into the
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2011-08-31 11:18:39
Message-ID: 20110831111839.17228.29578 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Aug. 31, 2011, 11:15 a.m., Antonis Tsiapaliokas wrote:
> > in the files toolbar, there is a row with name "Metadata", in which in the \
> > "Plugin Details" there is KComboBox with name "API". Unfortunately the KComboBox \
> > is stuck on "c++" all the time. Also there is no support for understanding in \
> > which language the plugin has been written. So here is my idea, first i should \
> > fix the bug about the Metadata and after that i will use that to make the current \
> > patch better.
that sounds perfect :)
the API entry should be pulled from the X-Plasma-API= entry of the .desktop file; as \
they are things like "declarative" and "javascript", some translation will be needed. \
also, C++ shouldn't be shown in the metadata editor at all as Plasmate doesn't (on \
purpose) support c++ :)
- Aaron J.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102357/#review6188
-----------------------------------------------------------
On Aug. 17, 2011, 7:42 p.m., Antonis Tsiapaliokas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102357/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2011, 7:42 p.m.)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> Hello
>
> If you open the "files" toolbar and you try to add something new with the "New.." \
> in the executable scripts, then if you don't add the .{qml,js,rb,py}, then the file \
> will be saved without the mimetype extension. This patch is fixing this issue.If \
> you don't like something into the names which i gave, then let me know :)
>
> Diffs
> -----
>
> editors/editpage.cpp d4b0082
> packagemodel.h a14033c
> packagemodel.cpp 8c0907a
>
> Diff: http://git.reviewboard.kde.org/r/102357/diff
>
>
> Testing
> -------
>
> plasmate compiles fine. New files can be added into the other menus, without any \
> issue.
>
> Thanks,
>
> Antonis
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102357/">http://git.reviewboard.kde.org/r/102357/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 31st, 2011, 11:15 a.m., <b>Antonis \
Tsiapaliokas</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">in the files toolbar, there is a row with name "Metadata", in \
which in the "Plugin Details" there is KComboBox with name "API". \
Unfortunately the KComboBox is stuck on "c++" all the time. Also there is \
no support for understanding in which language the plugin has been written. So here \
is my idea, first i should fix the bug about the Metadata and after that i will use \
that to make the current patch better.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">that sounds perfect :)
the API entry should be pulled from the X-Plasma-API= entry of the .desktop file; as \
they are things like "declarative" and "javascript", some \
translation will be needed. also, C++ shouldn't be shown in the metadata editor \
at all as Plasmate doesn't (on purpose) support c++ :)</pre> <br />
<p>- Aaron J.</p>
<br />
<p>On August 17th, 2011, 7:42 p.m., Antonis Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Antonis Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated Aug. 17, 2011, 7:42 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello
If you open the "files" toolbar and you try to add something new with the \
"New.." in the executable scripts, then if you don't add the \
.{qml,js,rb,py}, then the file will be saved without the mimetype extension. This \
patch is fixing this issue.If you don't like something into the names which i \
gave, then let me know :)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">plasmate compiles fine. New files can be added into the other menus, \
without any issue. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>editors/editpage.cpp <span style="color: grey">(d4b0082)</span></li>
<li>packagemodel.h <span style="color: grey">(a14033c)</span></li>
<li>packagemodel.cpp <span style="color: grey">(8c0907a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102357/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic