--===============7007456194797109348== Content-Type: multipart/alternative; boundary="===============7363490980837033951==" --===============7363490980837033951== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Aug. 31, 2011, 11:15 a.m., Antonis Tsiapaliokas wrote: > > in the files toolbar, there is a row with name "Metadata", in which in = the "Plugin Details" there is KComboBox with name "API". Unfortunately the = KComboBox is stuck on "c++" all the time. Also there is no support for unde= rstanding in which language the plugin has been written. So here is my idea= , first i should fix the bug about the Metadata and after that i will use t= hat to make the current patch better. that sounds perfect :) the API entry should be pulled from the X-Plasma-API=3D entry of the .deskt= op file; as they are things like "declarative" and "javascript", some trans= lation will be needed. also, C++ shouldn't be shown in the metadata editor = at all as Plasmate doesn't (on purpose) support c++ :) - Aaron J. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102357/#review6188 ----------------------------------------------------------- On Aug. 17, 2011, 7:42 p.m., Antonis Tsiapaliokas wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102357/ > ----------------------------------------------------------- > = > (Updated Aug. 17, 2011, 7:42 p.m.) > = > = > Review request for Plasma. > = > = > Summary > ------- > = > Hello > = > If you open the "files" toolbar and you try to add something new with the= "New.." in the executable scripts, then if you don't add the .{qml,js,rb,p= y}, then the file will be saved without the mimetype extension. This patch = is fixing this issue.If you don't like something into the names which i gav= e, then let me know :) > = > = > Diffs > ----- > = > editors/editpage.cpp d4b0082 = > packagemodel.h a14033c = > packagemodel.cpp 8c0907a = > = > Diff: http://git.reviewboard.kde.org/r/102357/diff > = > = > Testing > ------- > = > plasmate compiles fine. New files can be added into the other menus, with= out any issue. = > = > = > Thanks, > = > Antonis > = > --===============7363490980837033951== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/102357/

On August 31st, 2011, 11:15 a.m., Antonis T= siapaliokas wrote:

in the fi=
les toolbar, there is a row with name "Metadata", in which in the=
 "Plugin Details" there is KComboBox with name "API". U=
nfortunately the KComboBox is stuck on "c++" all the time. Also t=
here is no support for understanding in which language the plugin has been =
written. So here is my idea, first i should fix the bug about the Metadata =
and after that i will use that to make the current patch better.

that sounds=
 perfect :)

the API entry should be pulled from the X-Plasma-API=3D entry of the .deskt=
op file; as they are things like "declarative" and "javascri=
pt", some translation will be needed. also, C++ shouldn't be shown=
 in the metadata editor at all as Plasmate doesn't (on purpose) support=
 c++ :)

- Aaron J.

On August 17th, 2011, 7:42 p.m., Antonis Tsiapaliokas wrote:

Review request for Plasma.

By Antonis Tsiapaliokas.

Updated Aug. 17, 2011, 7:42 p.m.

Descripti= on

Hello

If you open the "files" toolbar and you try to add something new =
with the "New.." in the executable scripts, then if you don't=
 add the .{qml,js,rb,py}, then the file will be saved without the mimetype =
extension. This patch is fixing this issue.If you don't like something =
into the names which i gave, then let me know :)

Testing <= /h1>

plasmate compiles fine. New files can be added into the othe=
r menus, without any issue. =

Diffs=

editors/editpage.cpp (d4b0082)
packagemodel.h (a14033c)
packagemodel.cpp (8c0907a)

--===============7363490980837033951==-- --===============7007456194797109348== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============7007456194797109348==--