[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Improve formatting of the events display on the
From: "Commit Hook" <null () kde ! org>
Date: 2011-08-17 7:12:49
Message-ID: 20110817071249.30541.42008 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102293/#review5762
-----------------------------------------------------------
This review has been submitted with commit d84ab98607be9a5cafa362b1ff5377be=
fa400874 by Lasse Liehu to branch master.
- Commit
On Aug. 17, 2011, 7:03 a.m., Lasse Liehu wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102293/
> -----------------------------------------------------------
> =
> (Updated Aug. 17, 2011, 7:03 a.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Summary
> -------
> =
> QDate::toString()'s date formatting doesn't work nicely for all languages=
and calendar systems, so changed to use KCalendarSystem for it. Also decre=
ases indentation so less space is wasted horizontally.
> =
> =
> Diffs
> -----
> =
> libs/plasmaclock/calendar.cpp e1c7bc6 =
> =
> Diff: http://git.reviewboard.kde.org/r/102293/diff
> =
> =
> Testing
> -------
> =
> Compiles, formatting works. See screenshots
> =
> =
> Screenshots
> -----------
> =
> Coptic calendar
> http://git.reviewboard.kde.org/r/102293/s/229/
> Correct Finnish formatting
> http://git.reviewboard.kde.org/r/102293/s/230/
> English (US) formatting
> http://git.reviewboard.kde.org/r/102293/s/231/
> =
> =
> Thanks,
> =
> Lasse
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102293/">http://git.reviewboard.kde.org/r/102293/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit d84ab98607be9a5cafa362b1ff5377befa400874 by Lasse Liehu to \
branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On August 17th, 2011, 7:03 a.m., Lasse Liehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Lasse Liehu.</div>
<p style="color: grey;"><i>Updated Aug. 17, 2011, 7:03 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">QDate::toString()'s date formatting doesn't work nicely for all \
languages and calendar systems, so changed to use KCalendarSystem for it. Also \
decreases indentation so less space is wasted horizontally.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiles, formatting works. See screenshots</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/plasmaclock/calendar.cpp <span style="color: grey">(e1c7bc6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102293/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/102293/s/229/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/08/15/screenshot2_400x100.png" \
style="border: 1px black solid;" alt="Coptic calendar" /></a>
<a href="http://git.reviewboard.kde.org/r/102293/s/230/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/08/15/screenshot1_400x100.png" \
style="border: 1px black solid;" alt="Correct Finnish formatting" /></a>
<a href="http://git.reviewboard.kde.org/r/102293/s/231/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/08/15/screenshot3_400x100.png" \
style="border: 1px black solid;" alt="English (US) formatting" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic