From kde-panel-devel Wed Aug 17 07:12:49 2011 From: "Commit Hook" Date: Wed, 17 Aug 2011 07:12:49 +0000 To: kde-panel-devel Subject: Re: Review Request: Improve formatting of the events display on the Message-Id: <20110817071249.30541.42008 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=131356530727099 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============7172195510080466929==" --===============7172195510080466929== Content-Type: multipart/alternative; boundary="===============3108516821441639083==" --===============3108516821441639083== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102293/#review5762 ----------------------------------------------------------- This review has been submitted with commit d84ab98607be9a5cafa362b1ff5377be= fa400874 by Lasse Liehu to branch master. - Commit On Aug. 17, 2011, 7:03 a.m., Lasse Liehu wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102293/ > ----------------------------------------------------------- > = > (Updated Aug. 17, 2011, 7:03 a.m.) > = > = > Review request for Plasma. > = > = > Summary > ------- > = > QDate::toString()'s date formatting doesn't work nicely for all languages= and calendar systems, so changed to use KCalendarSystem for it. Also decre= ases indentation so less space is wasted horizontally. > = > = > Diffs > ----- > = > libs/plasmaclock/calendar.cpp e1c7bc6 = > = > Diff: http://git.reviewboard.kde.org/r/102293/diff > = > = > Testing > ------- > = > Compiles, formatting works. See screenshots > = > = > Screenshots > ----------- > = > Coptic calendar > http://git.reviewboard.kde.org/r/102293/s/229/ > Correct Finnish formatting > http://git.reviewboard.kde.org/r/102293/s/230/ > English (US) formatting > http://git.reviewboard.kde.org/r/102293/s/231/ > = > = > Thanks, > = > Lasse > = > --===============3108516821441639083== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/102293/

This revie=
w has been submitted with commit d84ab98607be9a5cafa362b1ff5377befa400874 b=
y Lasse Liehu to branch master.

- Commit

On August 17th, 2011, 7:03 a.m., Lasse Liehu wrote:

Review request for Plasma.

By Lasse Liehu.

Updated Aug. 17, 2011, 7:03 a.m.

Descripti= on

QDate::toString()'s date formatting doesn't work nic=
ely for all languages and calendar systems, so changed to use KCalendarSyst=
em for it. Also decreases indentation so less space is wasted horizontally.=

Testing <= /h1>

Compiles, formatting works. See screenshots

Diffs=

libs/plasmaclock/calendar.cpp (e1c7bc6)

View Diff

Screensho= ts

--===============3108516821441639083==-- --===============7172195510080466929== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============7172195510080466929==--