'Re: Review Request: Add missing parenthesis for classic menu item'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Add missing parenthesis for classic menu item
From:       "Commit Hook" <null () kde ! org>
Date:       2011-07-24 10:31:43
Message-ID: 20110724103143.700.83319 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102048/#review5023
-----------------------------------------------------------

This review has been submitted with commit 13c4705bdf785389695e7e62001cace72b77467a \
by Burkhard Lück to branch master.

- Commit

On July 22, 2011, 12:51 p.m., Burkhard Lück wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102048/
> -----------------------------------------------------------
> 
> (Updated July 22, 2011, 12:51 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> plasma/desktop/applets/kickoff/simpleapplet/simpleapplet.cpp:465 reads
> 
> i18nc("@item:inlistbox Format:", "Name Description"), \
> MenuLauncherApplet::NameDescription); 
> But that does not match \
> plasma/desktop/applets/kickoff/simpleapplet/menuview.cpp:190 
> if (d->formattype == NameDescription) {
> action->setText(QString("%1 (%2)").arg(name).arg(text));
> 
> 
> Diffs
> -----
> 
> plasma/desktop/applets/kickoff/simpleapplet/simpleapplet.cpp eb9a0c3 
> 
> Diff: http://git.reviewboard.kde.org/r/102048/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Burkhard
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102048/">http://git.reviewboard.kde.org/r/102048/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 13c4705bdf785389695e7e62001cace72b77467a by Burkhard Lück to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On July 22nd, 2011, 12:51 p.m., Burkhard Lück wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Burkhard Lück.</div>

<p style="color: grey;"><i>Updated July 22, 2011, 12:51 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">plasma/desktop/applets/kickoff/simpleapplet/simpleapplet.cpp:465 reads

i18nc(&quot;@item:inlistbox Format:&quot;, &quot;Name Description&quot;), \
MenuLauncherApplet::NameDescription);

But that does not match plasma/desktop/applets/kickoff/simpleapplet/menuview.cpp:190

if (d-&gt;formattype == NameDescription) {
    action-&gt;setText(QString(&quot;%1 (%2)&quot;).arg(name).arg(text));
</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/desktop/applets/kickoff/simpleapplet/simpleapplet.cpp <span style="color: \
grey">(eb9a0c3)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102048/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 