From kde-panel-devel Sun Jul 24 10:31:43 2011 From: "Commit Hook" Date: Sun, 24 Jul 2011 10:31:43 +0000 To: kde-panel-devel Subject: Re: Review Request: Add missing parenthesis for classic menu item Message-Id: <20110724103143.700.83319 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=131150355624960 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1523986061==" --===============1523986061== Content-Type: multipart/alternative; boundary="===============7352961610581660792==" --===============7352961610581660792== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102048/#review5023 ----------------------------------------------------------- This review has been submitted with commit 13c4705bdf785389695e7e62001cace7= 2b77467a by Burkhard L=C3=BCck to branch master. - Commit On July 22, 2011, 12:51 p.m., Burkhard L=C3=BCck wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102048/ > ----------------------------------------------------------- > = > (Updated July 22, 2011, 12:51 p.m.) > = > = > Review request for Plasma. > = > = > Summary > ------- > = > plasma/desktop/applets/kickoff/simpleapplet/simpleapplet.cpp:465 reads > = > i18nc("@item:inlistbox Format:", "Name Description"), MenuLauncherApplet:= :NameDescription); > = > But that does not match plasma/desktop/applets/kickoff/simpleapplet/menuv= iew.cpp:190 > = > if (d->formattype =3D=3D NameDescription) { > action->setText(QString("%1 (%2)").arg(name).arg(text)); > = > = > Diffs > ----- > = > plasma/desktop/applets/kickoff/simpleapplet/simpleapplet.cpp eb9a0c3 = > = > Diff: http://git.reviewboard.kde.org/r/102048/diff > = > = > Testing > ------- > = > = > Thanks, > = > Burkhard > = > --===============7352961610581660792== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/102048/ 

This revie=
w has been submitted with commit 13c4705bdf785389695e7e62001cace72b77467a b=
y Burkhard L=C3=BCck to branch master.

- Commit


On July 22nd, 2011, 12:51 p.m., Burkhard L=C3=BCck wrote:

Review request for Plasma.
By Burkhard L=C3=BCck.

Updated July 22, 2011, 12:51 p.m.

Descripti= on 

plasma/desktop/applets/kickoff/simpleapplet/simpleapplet.cpp=
:465 reads

i18nc("@item:inlistbox Format:", "Name Description"), M=
enuLauncherApplet::NameDescription);

But that does not match plasma/desktop/applets/kickoff/simpleapplet/menuvie=
w.cpp:190

if (d->formattype =3D=3D NameDescription) {
    action->setText(QString("%1 (%2)").arg(name).arg(text));

Diffs=

  • plasma/desktop/applets/kickoff/simpleapplet/simpleapplet.cpp (eb9a0c3)

View Diff
--===============7352961610581660792==-- --===============1523986061== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============1523986061==--