[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Fix notification adjustPosition on resizeEven
From: "Commit Hook" <null () kde ! org>
Date: 2011-07-19 19:12:40
Message-ID: 20110719191240.4100.48519 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101981/#review4864
-----------------------------------------------------------
This review has been submitted with commit 7e8675b11baedc95eb388665f5f44f21=
4b187a86 by Alex Fiestas to branch KDE/4.7.
- Commit
On July 17, 2011, 6:49 p.m., Alex Fiestas wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101981/
> -----------------------------------------------------------
> =
> (Updated July 17, 2011, 6:49 p.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Summary
> -------
> =
> On resizeEvent adjustPosition will be called so the widget can update the=
position in relation with the new size. The problem before this patch is t=
hat the code is not taking into account the position of the notification, w=
hether it is closer to the top or to the bottom.
> =
> The current behavior is correct if the notification is closer to the top =
but it is incorrect if the notification is closer to the bottom since in th=
at case we want the notification to increment the Y if the old size was big=
ger than the current size.
> =
> I can't find better words to describe the problem, so I will attach a scr=
eenshot.
> =
> =
> Diffs
> -----
> =
> plasma/generic/applets/notifications/ui/stackdialog.h 89c36a9 =
> plasma/generic/applets/notifications/ui/stackdialog.cpp 0d3f6a0 =
> =
> Diff: http://git.reviewboard.kde.org/r/101981/diff
> =
> =
> Testing
> -------
> =
> Everything I could think of:
> 1-Notifications in each corner of the screen
> 2-Notifications "gap" into a side.
> 3-Notifications at the middle
> =
> So far, so good!
> =
> =
> Screenshots
> -----------
> =
> Notification Wrong pos
> http://git.reviewboard.kde.org/r/101981/s/204/
> =
> =
> Thanks,
> =
> Alex
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101981/">http://git.reviewboard.kde.org/r/101981/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit \
7e8675b11baedc95eb388665f5f44f214b187a86 by Alex Fiestas to branch KDE/4.7.</pre> <br />
<p>- Commit</p>
<br />
<p>On July 17th, 2011, 6:49 p.m., Alex Fiestas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Alex Fiestas.</div>
<p style="color: grey;"><i>Updated July 17, 2011, 6:49 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">On resizeEvent \
adjustPosition will be called so the widget can update the position in relation with the new \
size. The problem before this patch is that the code is not taking into account the position of \
the notification, whether it is closer to the top or to the bottom.
The current behavior is correct if the notification is closer to the top but it is incorrect if \
the notification is closer to the bottom since in that case we want the notification to \
increment the Y if the old size was bigger than the current size.
I can't find better words to describe the problem, so I will attach a screenshot.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Everything I could \
think of: 1-Notifications in each corner of the screen
2-Notifications "gap" into a side.
3-Notifications at the middle
So far, so good!</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/notifications/ui/stackdialog.h <span style="color: \
grey">(89c36a9)</span></li>
<li>plasma/generic/applets/notifications/ui/stackdialog.cpp <span style="color: \
grey">(0d3f6a0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101981/diff/" style="margin-left: 3em;">View \
Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/101981/s/204/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/07/17/notiWrong_400x100.png" \
style="border: 1px black solid;" alt="Notification Wrong pos" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic