From kde-panel-devel Tue Jul 19 19:12:40 2011 From: "Commit Hook" Date: Tue, 19 Jul 2011 19:12:40 +0000 To: kde-panel-devel Subject: Re: Review Request: Fix notification adjustPosition on resizeEven Message-Id: <20110719191240.4100.48519 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=131110281417256 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1459159780==" --===============1459159780== Content-Type: multipart/alternative; boundary="===============6984122222414188252==" --===============6984122222414188252== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101981/#review4864 ----------------------------------------------------------- This review has been submitted with commit 7e8675b11baedc95eb388665f5f44f21= 4b187a86 by Alex Fiestas to branch KDE/4.7. - Commit On July 17, 2011, 6:49 p.m., Alex Fiestas wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101981/ > ----------------------------------------------------------- > = > (Updated July 17, 2011, 6:49 p.m.) > = > = > Review request for Plasma. > = > = > Summary > ------- > = > On resizeEvent adjustPosition will be called so the widget can update the= position in relation with the new size. The problem before this patch is t= hat the code is not taking into account the position of the notification, w= hether it is closer to the top or to the bottom. > = > The current behavior is correct if the notification is closer to the top = but it is incorrect if the notification is closer to the bottom since in th= at case we want the notification to increment the Y if the old size was big= ger than the current size. > = > I can't find better words to describe the problem, so I will attach a scr= eenshot. > = > = > Diffs > ----- > = > plasma/generic/applets/notifications/ui/stackdialog.h 89c36a9 = > plasma/generic/applets/notifications/ui/stackdialog.cpp 0d3f6a0 = > = > Diff: http://git.reviewboard.kde.org/r/101981/diff > = > = > Testing > ------- > = > Everything I could think of: > 1-Notifications in each corner of the screen > 2-Notifications "gap" into a side. > 3-Notifications at the middle > = > So far, so good! > = > = > Screenshots > ----------- > = > Notification Wrong pos > http://git.reviewboard.kde.org/r/101981/s/204/ > = > = > Thanks, > = > Alex > = > --===============6984122222414188252== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/101981/ 

This revie=
w has been submitted with commit 7e8675b11baedc95eb388665f5f44f214b187a86 b=
y Alex Fiestas to branch KDE/4.7.

- Commit


On July 17th, 2011, 6:49 p.m., Alex Fiestas wrote:

Review request for Plasma.
By Alex Fiestas.

Updated July 17, 2011, 6:49 p.m.

Descripti= on 

On resizeEvent adjustPosition will be called so the widget c=
an update the position in relation with the new size. The problem before th=
is patch is that the code is not taking into account the position of the no=
tification, whether it is closer to the top or to the bottom.

The current behavior is correct if the notification is closer to the top bu=
t it is incorrect if the notification is closer to the bottom since in that=
 case we want the notification to increment the Y if the old size was bigge=
r than the current size.

I can't find better words to describe the problem, so I will attach a s=
creenshot.

Testing <= /h1> 
Everything I could think of:
1-Notifications in each corner of the screen
2-Notifications "gap" into a side.
3-Notifications at the middle

So far, so good!

Diffs=

  • plasma/generic/applets/notifications/ui/stackdialog.h (89c36a9)
  • plasma/generic/applets/notifications/ui/stackdialog.cpp (0d3f6a0)

View Diff

Screensho= ts

3D"Notification
--===============6984122222414188252==-- --===============1459159780== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============1459159780==--