[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Plasmate:void ProjectManager::removeDirectory
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2011-07-13 17:25:07
Message-ID: 20110713172507.2549.20034 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101550/#review4691
-----------------------------------------------------------
=1Bthere is a problem with the cd(".."),otherwise it looks good. just need =
to fix that up and it can go in.
projectmanager/projectmanager.cpp
<http://git.reviewboard.kde.org/r/101550/#comment4132>
this cd("..") does not look safe. it assumes that it is a project creat=
ed by plasmate, and so has the code one level beneath the actual project di=
r.
=
however, one can easily import an existing project from disk. say .. ~/=
myPreexistingProject. which means this could would delete everything in my =
home dir!
=
i actually have some projects imported from kdeexamples as well as one =
from a local git repo, and this would wreck havoc on my data :/
=
as nasty as this is going to look, i think what will be required is to =
check if projectLocation is in appdata or not.
- Aaron J.
On July 13, 2011, 3 p.m., Giorgos Tsiapaliwkas wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101550/
> -----------------------------------------------------------
> =
> (Updated July 13, 2011, 3 p.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Summary
> -------
> =
> Hello,
> =
> the method removeDirectory wasn't removing the parent folder. =
> For example,if we named out plasmoid my_plasmoid it would have a director=
y like this "$(kde4-config --localprefix)/share/apps/plasmate/my_plasmoid/m=
y_plasmoid" and the after calling the removeDirectory(before the patch) met=
hod we would have a directory like this:
> ""$(kde4-config --localprefix)/share/apps/plasmate/my_plasmoid/NOTES".
> With the patch the entire folder my_plasmoid is being deleted.
> =
> =
> Diffs
> -----
> =
> projectmanager/projectmanager.h 53ef226 =
> projectmanager/projectmanager.cpp 122e48d =
> =
> Diff: http://git.reviewboard.kde.org/r/101550/diff
> =
> =
> Testing
> -------
> =
> compiles without issues and without regressions.
> =
> =
> Thanks,
> =
> Giorgos
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101550/">http://git.reviewboard.kde.org/r/101550/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">there is a problem with \
the cd(".."),otherwise it looks good. just need to fix that up and it can \
go in.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/101550/diff/2/?file=26951#file26951line230" \
style="color: black; font-weight: bold; text-decoration: \
underline;">projectmanager/projectmanager.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
ProjectManager::setRecentProjects(const QStringList &paths)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">229</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="p">}</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">228</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">project</span><span \
class="p">.</span><span class="n">cd</span><span class="p">(</span><span \
class="s">".."</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this \
cd("..") does not look safe. it assumes that it is a project created by \
plasmate, and so has the code one level beneath the actual project dir.
however, one can easily import an existing project from disk. say .. \
~/myPreexistingProject. which means this could would delete everything in my home \
dir!
i actually have some projects imported from kdeexamples as well as one from a local \
git repo, and this would wreck havoc on my data :/
as nasty as this is going to look, i think what will be required is to check if \
projectLocation is in appdata or not.</pre> </div>
<br />
<p>- Aaron J.</p>
<br />
<p>On July 13th, 2011, 3 p.m., Giorgos Tsiapaliwkas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliwkas.</div>
<p style="color: grey;"><i>Updated July 13, 2011, 3 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello,
the method removeDirectory wasn't removing the parent folder.
For example,if we named out plasmoid my_plasmoid it would have a directory like this \
"$(kde4-config --localprefix)/share/apps/plasmate/my_plasmoid/my_plasmoid" \
and the after calling the removeDirectory(before the patch) method we would have a \
directory like this: ""$(kde4-config \
--localprefix)/share/apps/plasmate/my_plasmoid/NOTES". With the patch the entire \
folder my_plasmoid is being deleted.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">compiles without issues and without regressions.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>projectmanager/projectmanager.h <span style="color: grey">(53ef226)</span></li>
<li>projectmanager/projectmanager.cpp <span style="color: \
grey">(122e48d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101550/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic