'Re: Review Request: Use underscore instead of hyphen in .so name'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Use underscore instead of hyphen in .so name
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2011-06-29 9:32:46
Message-ID: 20110629093246.30179.16435 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101801/#review4254
-----------------------------------------------------------

yes, it's unfortunately inconsistent. however, is there any particular reas=
on to change it at this point, other than to improve said consistency? if n=
ot, i'm not sure it's worth doing.

- Aaron J.

On June 29, 2011, 12:39 a.m., Christoph Feck wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101801/
> -----------------------------------------------------------
> =

> (Updated June 29, 2011, 12:39 a.m.)
> =

> =

> Review request for Plasma.
> =

> =

> Summary
> -------
> =

> Every other applet uses "plasma_applet_name.so", but systemloadviewer use=
s "plasma-applet_name.so". This should fix it, but I don't know if I can sa=
fely change the .so name.
> =

> =

> Diffs
> -----
> =

>   applets/systemloadviewer/CMakeLists.txt 6de867a =

>   applets/systemloadviewer/plasma-applet-systemloadviewer.desktop 5311d2c =

> =

> Diff: http://git.reviewboard.kde.org/r/101801/diff
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Christoph
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/101801/">http://git.reviewboard.kde.org/r/101801/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yes, it&#39;s \
unfortunately inconsistent. however, is there any particular reason to change it at \
this point, other than to improve said consistency? if not, i&#39;m not sure it&#39;s \
worth doing.</pre>  <br />

<p>- Aaron J.</p>

<br />
<p>On June 29th, 2011, 12:39 a.m., Christoph Feck wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Christoph Feck.</div>

<p style="color: grey;"><i>Updated June 29, 2011, 12:39 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Every other applet uses &quot;plasma_applet_name.so&quot;, but \
systemloadviewer uses &quot;plasma-applet_name.so&quot;. This should fix it, but I \
don&#39;t know if I can safely change the .so name.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/systemloadviewer/CMakeLists.txt <span style="color: \
grey">(6de867a)</span></li>

 <li>applets/systemloadviewer/plasma-applet-systemloadviewer.desktop <span \
style="color: grey">(5311d2c)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/101801/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 