--===============1296340125== Content-Type: multipart/alternative; boundary="===============6487827183721849012==" --===============6487827183721849012== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101801/#review4254 ----------------------------------------------------------- yes, it's unfortunately inconsistent. however, is there any particular reas= on to change it at this point, other than to improve said consistency? if n= ot, i'm not sure it's worth doing. - Aaron J. On June 29, 2011, 12:39 a.m., Christoph Feck wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101801/ > ----------------------------------------------------------- > = > (Updated June 29, 2011, 12:39 a.m.) > = > = > Review request for Plasma. > = > = > Summary > ------- > = > Every other applet uses "plasma_applet_name.so", but systemloadviewer use= s "plasma-applet_name.so". This should fix it, but I don't know if I can sa= fely change the .so name. > = > = > Diffs > ----- > = > applets/systemloadviewer/CMakeLists.txt 6de867a = > applets/systemloadviewer/plasma-applet-systemloadviewer.desktop 5311d2c = > = > Diff: http://git.reviewboard.kde.org/r/101801/diff > = > = > Testing > ------- > = > = > Thanks, > = > Christoph > = > --===============6487827183721849012== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/101801/ 

yes, it=
9;s unfortunately inconsistent. however, is there any particular reason to =
change it at this point, other than to improve said consistency? if not, i&=
#39;m not sure it's worth doing.

- Aaron J.


On June 29th, 2011, 12:39 a.m., Christoph Feck wrote:

Review request for Plasma.
By Christoph Feck.

Updated June 29, 2011, 12:39 a.m.

Descripti= on 

Every other applet uses "plasma_applet_name.so", b=
ut systemloadviewer uses "plasma-applet_name.so". This should fix=
 it, but I don't know if I can safely change the .so name.

Diffs=

  • applets/systemloadviewer/CMakeLists.txt (6= de867a)
  • applets/systemloadviewer/plasma-applet-systemloadviewer.desktop (5311d2c)

View Diff
--===============6487827183721849012==-- --===============1296340125== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============1296340125==--