[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Fix bug 276082 and refactor timeline in plasmate
From: "Etienne Rebetez" <etienne.rebetez () oberwallis ! ch>
Date: 2011-06-27 13:54:43
Message-ID: 20110627135443.9059.87187 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On June 27, 2011, 11:51 a.m., Aaron J. Seigo wrote:
> > looks good, minus the two small memory leaks; i'm not as convinced that=
the direction of the timeline is "correct" but let's keep it this way for =
now. after fixing the two memory leaks, please commit... cheers :)
Yes, i am not convinced myself;) Putting the timelineitems in a separate sc=
rollbar could do the trick. But i'll try that in an other branch.
Thanks for your time.
Etienne
- Etienne
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101728/#review4196
-----------------------------------------------------------
On June 25, 2011, 10:01 p.m., Etienne Rebetez wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101728/
> -----------------------------------------------------------
> =
> (Updated June 25, 2011, 10:01 p.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Summary
> -------
> =
> Hi,
> =
> When trying out plasmate the last day, i was hit with the bug 276082. Sin=
ce i didn't want that it happens to someone else, i made a fix for it.
> I the process i found that the loadTimeLine function was far to big. So i=
did also some refactoring. (this diff is kinda huge but i made the changes=
in a branch which i can merge to master)
> The timeliene and savepoint creation should now behave as expected.
> =
> Let me know what you think.
> Etienne
> =
> PS: How is the commit policy in plasmate? Could i just push directly to m=
aster in the future?
> =
> =
> Diffs
> -----
> =
> mainwindow.cpp 8326a29 =
> savesystem/tablewidget.cpp 39e8761 =
> savesystem/timeline.h 719fb73 =
> savesystem/timeline.cpp d258a1a =
> savesystem/timelineitem.h 1e9699f =
> savesystem/timelineitem.cpp d9b0a67 =
> =
> Diff: http://git.reviewboard.kde.org/r/101728/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Etienne
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101728/">http://git.reviewboard.kde.org/r/101728/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 27th, 2011, 11:51 a.m., <b>Aaron J. \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">looks good, minus the two small memory leaks; i'm not as convinced \
that the direction of the timeline is "correct" but let's keep it this \
way for now. after fixing the two memory leaks, please commit... cheers :)</pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, i am not convinced \
myself;) Putting the timelineitems in a separate scrollbar could do the trick. But \
i'll try that in an other branch. Thanks for your time.
Etienne</pre>
<br />
<p>- Etienne</p>
<br />
<p>On June 25th, 2011, 10:01 p.m., Etienne Rebetez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Etienne Rebetez.</div>
<p style="color: grey;"><i>Updated June 25, 2011, 10:01 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hi,
When trying out plasmate the last day, i was hit with the bug 276082. Since i \
didn't want that it happens to someone else, i made a fix for it. I the process i \
found that the loadTimeLine function was far to big. So i did also some refactoring. \
(this diff is kinda huge but i made the changes in a branch which i can merge to \
master) The timeliene and savepoint creation should now behave as expected.
Let me know what you think.
Etienne
PS: How is the commit policy in plasmate? Could i just push directly to master in the \
future?</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>mainwindow.cpp <span style="color: grey">(8326a29)</span></li>
<li>savesystem/tablewidget.cpp <span style="color: grey">(39e8761)</span></li>
<li>savesystem/timeline.h <span style="color: grey">(719fb73)</span></li>
<li>savesystem/timeline.cpp <span style="color: grey">(d258a1a)</span></li>
<li>savesystem/timelineitem.h <span style="color: grey">(1e9699f)</span></li>
<li>savesystem/timelineitem.cpp <span style="color: grey">(d9b0a67)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101728/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic