From kde-panel-devel Mon Jun 27 13:54:43 2011 From: "Etienne Rebetez" Date: Mon, 27 Jun 2011 13:54:43 +0000 To: kde-panel-devel Subject: Re: Review Request: Fix bug 276082 and refactor timeline in plasmate Message-Id: <20110627135443.9059.87187 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=130918294025715 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0738359838==" --===============0738359838== Content-Type: multipart/alternative; boundary="===============3776115387322357878==" --===============3776115387322357878== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On June 27, 2011, 11:51 a.m., Aaron J. Seigo wrote: > > looks good, minus the two small memory leaks; i'm not as convinced that= the direction of the timeline is "correct" but let's keep it this way for = now. after fixing the two memory leaks, please commit... cheers :) Yes, i am not convinced myself;) Putting the timelineitems in a separate sc= rollbar could do the trick. But i'll try that in an other branch. Thanks for your time. Etienne - Etienne ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101728/#review4196 ----------------------------------------------------------- On June 25, 2011, 10:01 p.m., Etienne Rebetez wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101728/ > ----------------------------------------------------------- > = > (Updated June 25, 2011, 10:01 p.m.) > = > = > Review request for Plasma. > = > = > Summary > ------- > = > Hi, > = > When trying out plasmate the last day, i was hit with the bug 276082. Sin= ce i didn't want that it happens to someone else, i made a fix for it. > I the process i found that the loadTimeLine function was far to big. So i= did also some refactoring. (this diff is kinda huge but i made the changes= in a branch which i can merge to master) > The timeliene and savepoint creation should now behave as expected. > = > Let me know what you think. > Etienne > = > PS: How is the commit policy in plasmate? Could i just push directly to m= aster in the future? > = > = > Diffs > ----- > = > mainwindow.cpp 8326a29 = > savesystem/tablewidget.cpp 39e8761 = > savesystem/timeline.h 719fb73 = > savesystem/timeline.cpp d258a1a = > savesystem/timelineitem.h 1e9699f = > savesystem/timelineitem.cpp d9b0a67 = > = > Diff: http://git.reviewboard.kde.org/r/101728/diff > = > = > Testing > ------- > = > = > Thanks, > = > Etienne > = > --===============3776115387322357878== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/101728/

On June 27th, 2011, 11:51 a.m., Aaron J. Se= igo wrote:

looks goo=
d, minus the two small memory leaks; i'm not as convinced that the dire=
ction of the timeline is "correct" but let's keep it this way=
 for now. after fixing the two memory leaks, please commit... cheers :)
 
Yes, i am n=
ot convinced myself;) Putting the timelineitems in a separate scrollbar cou=
ld do the trick. But i'll try that in an other branch.
Thanks for your time.
Etienne

- Etienne


On June 25th, 2011, 10:01 p.m., Etienne Rebetez wrote:

Review request for Plasma.
By Etienne Rebetez.

Updated June 25, 2011, 10:01 p.m.

Descripti= on 

Hi,

When trying out plasmate the last day, i was hit with the bug 276082. Since=
 i didn't want that it happens to someone else, i made a fix for it.
I the process i found that the loadTimeLine function was far to big. So i d=
id also some refactoring. (this diff is kinda huge but i made the changes i=
n a branch which i can merge to master)
The timeliene and savepoint creation should now behave as expected.

Let me know what you think.
Etienne

PS: How is the commit policy in plasmate? Could i just push directly to mas=
ter in the future?

Diffs=

  • mainwindow.cpp (8326a29)
  • savesystem/tablewidget.cpp (39e8761)
  • savesystem/timeline.h (719fb73)
  • savesystem/timeline.cpp (d258a1a)
  • savesystem/timelineitem.h (1e9699f)=
  • savesystem/timelineitem.cpp (d9b0a67)

View Diff
--===============3776115387322357878==-- --===============0738359838== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============0738359838==--