'Re: Review Request: Fix bug 276082 and refactor timeline in plasmate'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Fix bug 276082 and refactor timeline in plasmate
From:       "Etienne Rebetez" <etienne.rebetez () oberwallis ! ch>
Date:       2011-06-25 22:01:29
Message-ID: 20110625220129.6997.40921 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101728/
-----------------------------------------------------------

(Updated June 25, 2011, 10:01 p.m.)

Review request for Plasma.

Changes
-------

During the process of coding and testing i realised the following:
 - Having the newest timelineitems on the left (horizontal) made sens, when=
 not all timelineitems are visible.
 - When vertical, it seams natural to have the newes timeline items on the =
top.

So this means the inital behavior was/is better and there is no bug:)

But since i allready lost data with the assumption that time goes from left=
 to right, i figured out that it has to be made clear what timelineitem you=
 are about to reset.
So i added the following:
 - The timelineitems show now the date/time as their text
 - The first item (oldest) is marked as such
 - A "create new savepoint" icon is placed where the new timelineitems are =
inserted
 - And the context menu of the timlineitems shows more information (tooltip=
 text)

The git log parsing is almost identical to the current one.

When closing a project and opening another, the timeline was not updated (s=
howed the old project). I fixed that too.

I also tried to set the whitspaces and brakets right.

Summary
-------

Hi,

When trying out plasmate the last day, i was hit with the bug 276082. Since=
 i didn't want that it happens to someone else, i made a fix for it.
I the process i found that the loadTimeLine function was far to big. So i d=
id also some refactoring. (this diff is kinda huge but i made the changes i=
n a branch which i can merge to master)
The timeliene and savepoint creation should now behave as expected.

Let me know what you think.
Etienne

PS: How is the commit policy in plasmate? Could i just push directly to mas=
ter in the future?

Diffs (updated)
-----

  mainwindow.cpp 8326a29 =

  savesystem/tablewidget.cpp 39e8761 =

  savesystem/timeline.h 719fb73 =

  savesystem/timeline.cpp d258a1a =

  savesystem/timelineitem.h 1e9699f =

  savesystem/timelineitem.cpp d9b0a67 =

Diff: http://git.reviewboard.kde.org/r/101728/diff

Testing
-------

Thanks,

Etienne

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/101728/">http://git.reviewboard.kde.org/r/101728/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Etienne Rebetez.</div>

<p style="color: grey;"><i>Updated June 25, 2011, 10:01 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">During the process of coding and testing i realised the \
                following:
 - Having the newest timelineitems on the left (horizontal) made sens, when not all \
                timelineitems are visible.
 - When vertical, it seams natural to have the newes timeline items on the top.

So this means the inital behavior was/is better and there is no bug:)

But since i allready lost data with the assumption that time goes from left to right, \
i figured out that it has to be made clear what timelineitem you are about to reset. \
                So i added the following:
 - The timelineitems show now the date/time as their text
 - The first item (oldest) is marked as such
 - A &quot;create new savepoint&quot; icon is placed where the new timelineitems are \
                inserted
 - And the context menu of the timlineitems shows more information (tooltip text)

The git log parsing is almost identical to the current one.

When closing a project and opening another, the timeline was not updated (showed the \
old project). I fixed that too.

I also tried to set the whitspaces and brakets right.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hi,

When trying out plasmate the last day, i was hit with the bug 276082. Since i \
didn&#39;t want that it happens to someone else, i made a fix for it. I the process i \
found that the loadTimeLine function was far to big. So i did also some refactoring. \
(this diff is kinda huge but i made the changes in a branch which i can merge to \
master) The timeliene and savepoint creation should now behave as expected.

Let me know what you think.
Etienne

PS: How is the commit policy in plasmate? Could i just push directly to master in the \
future?</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>mainwindow.cpp <span style="color: grey">(8326a29)</span></li>

 <li>savesystem/tablewidget.cpp <span style="color: grey">(39e8761)</span></li>

 <li>savesystem/timeline.h <span style="color: grey">(719fb73)</span></li>

 <li>savesystem/timeline.cpp <span style="color: grey">(d258a1a)</span></li>

 <li>savesystem/timelineitem.h <span style="color: grey">(1e9699f)</span></li>

 <li>savesystem/timelineitem.cpp <span style="color: grey">(d9b0a67)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/101728/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 