[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Fix bug 276082 and refactor timeline in plasmate
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2011-06-24 7:39:16
Message-ID: 20110624073916.6174.99503 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On June 23, 2011, 6:29 p.m., Etienne Rebetez wrote:
> > savesystem/timeline.cpp, line 197
> > <http://git.reviewboard.kde.org/r/101728/diff/1/?file=24893#file24893line197>
> >
> > Thats, basicaly the fix. The idea was to have the commits in the list in the same \
> > order as they appear in the timeline. But, with your suggestion i'll probaly try \
> > to make the TimeLineItem in the same loop.
aha, ok, that makes lots of sense.. it is probably even worth providing a comment as \
to why it's "prepend" instead of "append"... i look forward to the updated version of \
this patch.. thanks again for working on fixing this!
- Aaron J.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101728/#review4104
-----------------------------------------------------------
On June 22, 2011, 7:37 p.m., Etienne Rebetez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101728/
> -----------------------------------------------------------
>
> (Updated June 22, 2011, 7:37 p.m.)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> Hi,
>
> When trying out plasmate the last day, i was hit with the bug 276082. Since i \
> didn't want that it happens to someone else, i made a fix for it. I the process i \
> found that the loadTimeLine function was far to big. So i did also some \
> refactoring. (this diff is kinda huge but i made the changes in a branch which i \
> can merge to master) The timeliene and savepoint creation should now behave as \
> expected.
> Let me know what you think.
> Etienne
>
> PS: How is the commit policy in plasmate? Could i just push directly to master in \
> the future?
>
> Diffs
> -----
>
> mainwindow.cpp 8326a29
> savesystem/timeline.h 719fb73
> savesystem/timeline.cpp d258a1a
> savesystem/timelineitem.h 1e9699f
> savesystem/timelineitem.cpp d9b0a67
>
> Diff: http://git.reviewboard.kde.org/r/101728/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Etienne
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101728/">http://git.reviewboard.kde.org/r/101728/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 23rd, 2011, 6:29 p.m., <b>Etienne \
Rebetez</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/101728/diff/1/?file=24893#file24893line197" \
style="color: black; font-weight: bold; text-decoration: \
underline;">savesystem/timeline.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">TimeLine::TimeLine(QWidget *parent,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">184</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">commitList</span><span class="p">.</span><span \
class="n">prepend</span><span class="p">(</span><span class="n">commit</span><span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thats, basicaly the fix. \
The idea was to have the commits in the list in the same order as they appear in the \
timeline. But, with your suggestion i'll probaly try to make the TimeLineItem in \
the same loop.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">aha, ok, \
that makes lots of sense.. it is probably even worth providing a comment as to why \
it's "prepend" instead of "append"... i look forward to the \
updated version of this patch.. thanks again for working on fixing this!</pre> <br />
<p>- Aaron J.</p>
<br />
<p>On June 22nd, 2011, 7:37 p.m., Etienne Rebetez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Etienne Rebetez.</div>
<p style="color: grey;"><i>Updated June 22, 2011, 7:37 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hi,
When trying out plasmate the last day, i was hit with the bug 276082. Since i \
didn't want that it happens to someone else, i made a fix for it. I the process i \
found that the loadTimeLine function was far to big. So i did also some refactoring. \
(this diff is kinda huge but i made the changes in a branch which i can merge to \
master) The timeliene and savepoint creation should now behave as expected.
Let me know what you think.
Etienne
PS: How is the commit policy in plasmate? Could i just push directly to master in the \
future?</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>mainwindow.cpp <span style="color: grey">(8326a29)</span></li>
<li>savesystem/timeline.h <span style="color: grey">(719fb73)</span></li>
<li>savesystem/timeline.cpp <span style="color: grey">(d258a1a)</span></li>
<li>savesystem/timelineitem.h <span style="color: grey">(1e9699f)</span></li>
<li>savesystem/timelineitem.cpp <span style="color: grey">(d9b0a67)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101728/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic