'Re: Review Request: Plasmate:fixes an issue with QDockwidget at the'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Plasmate:fixes an issue with QDockwidget at the
From:       Sebastian_Kügler <sebas () kde ! org>
Date:       2011-06-16 11:00:26
Message-ID: 20110616110026.25607.70493 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101612/#review3929
-----------------------------------------------------------

Ship it!

If it's possible to show only the previously selected dockwidgets once we'r=
e in the editing interface, this patch is fine :)

- Sebastian

On June 14, 2011, 11:19 a.m., Giorgos Tsiapaliwkas wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101612/
> -----------------------------------------------------------
> =

> (Updated June 14, 2011, 11:19 a.m.)
> =

> =

> Review request for Plasma and Aaron J. Seigo.
> =

> =

> Summary
> -------
> =

> hello,
> =

> this patch fixes an issue that i noticed lately with the showstartpage() =
(file-close project).If i was selected any of the qdockwidget such as,the p=
reviewer,after the call of showstartpage the qdockwidget was remaining visi=
ble.
> =

> =

> Diffs
> -----
> =

>   mainwindow.cpp 8326a29 =

> =

> Diff: http://git.reviewboard.kde.org/r/101612/diff
> =

> =

> Testing
> -------
> =

> tested by me.
> compiles fine without regressions
> =

> =

> Thanks,
> =

> Giorgos
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/101612/">http://git.reviewboard.kde.org/r/101612/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If it&#39;s possible to \
show only the previously selected dockwidgets once we&#39;re in the editing \
interface, this patch is fine :)</pre>  <br />

<p>- Sebastian</p>

<br />
<p>On June 14th, 2011, 11:19 a.m., Giorgos Tsiapaliwkas wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Aaron J. Seigo.</div>
<div>By Giorgos Tsiapaliwkas.</div>

<p style="color: grey;"><i>Updated June 14, 2011, 11:19 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">hello,

this patch fixes an issue that i noticed lately with the showstartpage() (file-close \
project).If i was selected any of the qdockwidget such as,the previewer,after the \
call of showstartpage the qdockwidget was remaining visible.

</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">tested by me. compiles fine without regressions</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>mainwindow.cpp <span style="color: grey">(8326a29)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/101612/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 