[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Plasmate:qcheckbox added and the removal buttons
From: Sebastian_Kügler <sebas () kde ! org>
Date: 2011-06-16 10:58:20
Message-ID: 20110616105820.25510.21807 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101585/#review3928
-----------------------------------------------------------
some remarks in here, some also apply to your other request.
Tip: If you create a request that "overrides" an older one, remove the olde=
r one :)
projectmanager/projectmanager.cpp
<http://git.reviewboard.kde.org/r/101585/#comment3207>
seems indentation is screwed here: use 4 spaces
projectmanager/projectmanager.cpp
<http://git.reviewboard.kde.org/r/101585/#comment3208>
shouldn't this just disable the button?
=
Also, space after comma
projectmanager/projectmanager.cpp
<http://git.reviewboard.kde.org/r/101585/#comment3209>
If no project is selected, simply disable() the button in question. Mak=
es it immediately clear.
=
In general, whenever you use a KMessageBox, think if you can prevent th=
e situation from appearing, as those popups are generally disturbing to the=
user and should be avoided by leading the user through the UI.
- Sebastian
On June 11, 2011, 5:03 p.m., Giorgos Tsiapaliwkas wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101585/
> -----------------------------------------------------------
> =
> (Updated June 11, 2011, 5:03 p.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Summary
> -------
> =
> hello,
> =
> the following patch is a summary of some other patches that i had to my l=
ocal repository.Because it is too difficult to make different request due t=
o share code i made 1 review request.(Sorry for the inconvinience.)
> =
> This patch shares code with these two.
> git.reviewboard.kde.org/r/101535/
> git.reviewboard.kde.org/r/101584/
> =
> The patch adds a Qcheckbox which enables the user to protect one project =
from the removal.
> Also the delete buttons were able to be used even if a project wasn't sel=
ected at all,with this patch not anymore.
> =
> The code lacks only in the storage possibility.Plasmate is not able to "r=
emember" which projects are selected or not,i will fix this later.
> =
> P.S.:i created the checkbox with some intelligence in order to work only =
when it is supposed to work.For example,only when the user selects a projec=
t.
> =
> =
> Diffs
> -----
> =
> projectmanager/projectmanager.h 2c5bff2 =
> projectmanager/projectmanager.cpp c00fd27 =
> =
> Diff: http://git.reviewboard.kde.org/r/101585/diff
> =
> =
> Testing
> -------
> =
> compiles fines,tested by me.
> =
> =
> Thanks,
> =
> Giorgos
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101585/">http://git.reviewboard.kde.org/r/101585/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">some remarks in here, \
some also apply to your other request.
Tip: If you create a request that "overrides" an older one, remove the \
older one :)</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/101585/diff/2/?file=24287#file24287line60" \
style="color: black; font-weight: bold; text-decoration: \
underline;">projectmanager/projectmanager.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">53</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">hoz</span><span class="o">-></span><span class="n">addWidget</span><span \
class="p">(</span><span class="n"><span class="hl">delete</span>Button</span><span \
class="p">);</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">60</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">hoz</span><span \
class="o">-></span><span class="n">addWidget</span><span class="p">(</span><span \
class="n">removeFromListButton</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">seems \
indentation is screwed here: use 4 spaces</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/101585/diff/2/?file=24287#file24287line77" \
style="color: black; font-weight: bold; text-decoration: \
underline;">projectmanager/projectmanager.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">77</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">dialogText</span> <span class="o">=</span> <span class="n">i18n</span><span \
class="p">(</span><span class="s">"You cannot remove this project,because the \
disable removal button is checked."</span><span class="p">);</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">shouldn't this just disable the button?
Also, space after comma</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/101585/diff/2/?file=24287#file24287line92" \
style="color: black; font-weight: bold; text-decoration: \
underline;">projectmanager/projectmanager.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">92</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span class="n">l</span><span \
class="p">.</span><span class="n">size</span><span class="p">()</span><span \
class="o">!=</span><span class="mi">1</span><span class="p">)</span> <span \
class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If no \
project is selected, simply disable() the button in question. Makes it immediately \
clear.
In general, whenever you use a KMessageBox, think if you can prevent the situation \
from appearing, as those popups are generally disturbing to the user and should be \
avoided by leading the user through the UI.</pre> </div>
<br />
<p>- Sebastian</p>
<br />
<p>On June 11th, 2011, 5:03 p.m., Giorgos Tsiapaliwkas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliwkas.</div>
<p style="color: grey;"><i>Updated June 11, 2011, 5:03 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">hello,
the following patch is a summary of some other patches that i had to my local \
repository.Because it is too difficult to make different request due to share code i \
made 1 review request.(Sorry for the inconvinience.)
This patch shares code with these two.
git.reviewboard.kde.org/r/101535/
git.reviewboard.kde.org/r/101584/
The patch adds a Qcheckbox which enables the user to protect one project from the \
removal. Also the delete buttons were able to be used even if a project wasn't \
selected at all,with this patch not anymore.
The code lacks only in the storage possibility.Plasmate is not able to \
"remember" which projects are selected or not,i will fix this later.
P.S.:i created the checkbox with some intelligence in order to work only when it is \
supposed to work.For example,only when the user selects a project.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">compiles fines,tested by me.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>projectmanager/projectmanager.h <span style="color: grey">(2c5bff2)</span></li>
<li>projectmanager/projectmanager.cpp <span style="color: \
grey">(c00fd27)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101585/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic