[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Review Request: Code review for the newspaper containment
From: "Aleix Pol Gonzalez" <aleixpol () gmail ! com>
Date: 2011-06-08 13:23:03
Message-ID: 20110608132303.20707.90853 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101543/
-----------------------------------------------------------
Review request for Plasma.
Summary
-------
While tracking down some problems in the Newspaper containment problems I d=
ecided to simplify a little its code. I think this makes it a little more r=
eadable.
Hope that helps.
Diffs
-----
plasma/containments/newspaper/appletscontainer.cpp 1ba4d83 =
Diff: http://git.reviewboard.kde.org/r/101543/diff
Testing
-------
Thanks,
Aleix
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101543/">http://git.reviewboard.kde.org/r/101543/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Aleix Pol Gonzalez.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">While tracking down some problems in the Newspaper containment problems \
I decided to simplify a little its code. I think this makes it a little more \
readable.
Hope that helps.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/containments/newspaper/appletscontainer.cpp <span style="color: \
grey">(1ba4d83)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101543/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic