[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Changes at the functionality of the delete button.
From: "Giorgos Tsiapaliwkas" <terietor () gmail ! com>
Date: 2011-06-08 12:14:11
Message-ID: 20110608121411.16354.79419 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101535/
-----------------------------------------------------------
(Updated June 8, 2011, 12:14 p.m.)
Review request for Plasma.
Changes
-------
my diff v3,i solved the issue.my personal settings for kate was corrupting =
the patch.
Summary
-------
Hello,
after a discussion with Aaron Seigo at the #plasma we decided to add a new =
button at the project manager which is named "Remove Project From List",whi=
ch deletes the project only from the list(not from disk).The delete button =
was renamed to "Remove Project From Disk".Also i consider it properly to ch=
ange the names of some function in order to be more relative with the butto=
ns names.As well i changed and the functionality of confirmdeletion() in or=
der to avoid using the same code twice.
Diffs (updated)
-----
projectmanager/projectmanager.h 2c5bff2 =
projectmanager/projectmanager.cpp c00fd27 =
Diff: http://git.reviewboard.kde.org/r/101535/diff
Testing
-------
compiles and runs without regressions.
tested by me.
Thanks,
Giorgos
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101535/">http://git.reviewboard.kde.org/r/101535/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliwkas.</div>
<p style="color: grey;"><i>Updated June 8, 2011, 12:14 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">my diff v3,i solved the issue.my personal settings for kate was \
corrupting the patch.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello,
after a discussion with Aaron Seigo at the #plasma we decided to add a new button at \
the project manager which is named "Remove Project From List",which deletes \
the project only from the list(not from disk).The delete button was renamed to \
"Remove Project From Disk".Also i consider it properly to change the names \
of some function in order to be more relative with the buttons names.As well i \
changed and the functionality of confirmdeletion() in order to avoid using the same \
code twice.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">compiles and runs without regressions. tested by me.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>projectmanager/projectmanager.h <span style="color: grey">(2c5bff2)</span></li>
<li>projectmanager/projectmanager.cpp <span style="color: \
grey">(c00fd27)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101535/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic