[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Preconfigurable plasmoids
From: "David Palacio" <dpalacio () orbitalibre ! org>
Date: 2011-05-05 2:22:06
Message-ID: 20110505022206.27278.55166 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On April 28, 2011, 9:19 p.m., Aaron J. Seigo wrote:
> > an interesting idea, but the configuration values should not appear in the \
> > metadata.desktop file. it not only bloats up the # of keys we have, it doesn't \
> > scale to plasmoids with more/different configuration.
> > i think this would make more sense as a .desktop + a KConfigGroup (could even be \
> > in the same file?) that holds the complete default configuration that is then \
> > copied over after the applet is created.
>
> David Palacio wrote:
> I am making a DBusLauncher base plasmoid to see how far this can get. It faces one \
> issue so far: How to make some entries in the [Configuration] group translatable? \
> (provided by the configuration desktop file). Some data should be translated (as \
> user facing strings) and some other must not be translated (as resources \
> identifiers).
(Note to self, this is not a chatroom)
In Techbase an article describes a way to extract the wanted messages:
http://techbase.kde.org/Development/Tutorials/Localization/i18n_Build_Systems#Translating_.desktop_Files
Also, KLocale seems to be the way to get the translated strings, if they exist in the \
language of interest.
Is there a better method?
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101251/#review2950
-----------------------------------------------------------
On May 4, 2011, 12:52 a.m., David Palacio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101251/
> -----------------------------------------------------------
>
> (Updated May 4, 2011, 12:52 a.m.)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> There is some code duplication in that some plasmoids share very much of program \
> logic but actually differ in just a setting. E.g. the recently made \
> ShowActivityManager plasmoid, which just is a DBus call launcher. The Icon plasmoid \
> is an example of this made right. I'd like to have more generic plasmoids. Even \
> better, I'd like to have an easy way to configure them. \
>
> Let's see the code. config.patch shows a way to load a config metadata file and \
> fill a designated plasmoid with the configuration data (metadata.desktop). We \
> search for a X-Plasma-ConfigApplet property that defines the plasmoid to configure \
> and load. Additional properties define the plasmoid settings. This allows us, for \
> example, to easily provide access to any webservice without code duplication. \
>
>
> Diffs
> -----
>
> plasma/data/servicetypes/plasma-applet.desktop 8fabddb
> plasma/pluginloader.cpp 43a5b7c
> plasma/tests/CMakeLists.txt 1d04aa5
> plasma/tests/plasmoidconfigtest.h PRE-CREATION
> plasma/tests/plasmoidconfigtest.cpp PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/101251/diff
>
>
> Testing
> -------
>
> Loading of plasmoids works.
>
> Testcase: Install these widgets:
> http://kde-look.org/content/show.php/Label?content=99881
> http://kde-look.org/content/show.php?content=141270
>
> Add configlabel to desktop.
>
>
> Thanks,
>
> David
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101251/">http://git.reviewboard.kde.org/r/101251/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 28th, 2011, 9:19 p.m., <b>Aaron J. \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">an interesting idea, but the configuration values should not appear in \
the metadata.desktop file. it not only bloats up the # of keys we have, it \
doesn't scale to plasmoids with more/different configuration.
i think this would make more sense as a .desktop + a KConfigGroup (could even be in \
the same file?) that holds the complete default configuration that is then copied \
over after the applet is created.</pre> </blockquote>
<p>On May 5th, 2011, 2:04 a.m., <b>David Palacio</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am making a \
DBusLauncher base plasmoid to see how far this can get. It faces one issue so far: \
How to make some entries in the [Configuration] group translatable? (provided by the \
configuration desktop file). Some data should be translated (as user facing strings) \
and some other must not be translated (as resources identifiers).</pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">(Note to self, this is \
not a chatroom)
In Techbase an article describes a way to extract the wanted messages:
http://techbase.kde.org/Development/Tutorials/Localization/i18n_Build_Systems#Translating_.desktop_Files
Also, KLocale seems to be the way to get the translated strings, if they exist in the \
language of interest.
Is there a better method?</pre>
<br />
<p>- David</p>
<br />
<p>On May 4th, 2011, 12:52 a.m., David Palacio wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Palacio.</div>
<p style="color: grey;"><i>Updated May 4, 2011, 12:52 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">There is some code duplication in that some plasmoids share very much of \
program logic but actually differ in just a setting. E.g. the recently made \
ShowActivityManager plasmoid, which just is a DBus call launcher. The Icon plasmoid \
is an example of this made right. I'd like to have more generic plasmoids. Even \
better, I'd like to have an easy way to configure them. \
Let's see the code. config.patch shows a way to load a config metadata file and \
fill a designated plasmoid with the configuration data (metadata.desktop). We search \
for a X-Plasma-ConfigApplet property that defines the plasmoid to configure and load. \
Additional properties define the plasmoid settings. This allows us, for example, to \
easily provide access to any webservice without code duplication. \
</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Loading of plasmoids works.
Testcase: Install these widgets:
http://kde-look.org/content/show.php/Label?content=99881
http://kde-look.org/content/show.php?content=141270
Add configlabel to desktop.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/data/servicetypes/plasma-applet.desktop <span style="color: \
grey">(8fabddb)</span></li>
<li>plasma/pluginloader.cpp <span style="color: grey">(43a5b7c)</span></li>
<li>plasma/tests/CMakeLists.txt <span style="color: grey">(1d04aa5)</span></li>
<li>plasma/tests/plasmoidconfigtest.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/tests/plasmoidconfigtest.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101251/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic