[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Fix geolocation dataengine compilation for gpsd
From: "Commit Hook" <null () kde ! org>
Date: 2011-04-28 11:37:32
Message-ID: 20110428113732.27618.98472 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101247/#review2941
-----------------------------------------------------------
This review has been submitted with commit \
a3009dd96e8519bcc205d75c29e18bbbb81fce03 by Rafael Fernández López.
- Commit
On April 28, 2011, 7:16 a.m., Rafael Fernández López wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101247/
> -----------------------------------------------------------
>
> (Updated April 28, 2011, 7:16 a.m.)
>
>
> Review request for Plasma and Petri Damstén.
>
>
> Summary
> -------
>
> This patch fixes compilation when GPSD_API_MAJOR_VERSION >= 5. The API \
> has changed and some calls are not compatible with the previous versions. \
> GPSD version here: 2.96.
>
> Diffs
> -----
>
> plasma/generic/dataengines/geolocation/location_gps.h 506d1d1
> plasma/generic/dataengines/geolocation/location_gps.cpp c44cb30
>
> Diff: http://git.reviewboard.kde.org/r/101247/diff
>
>
> Testing
> -------
>
> I wasn't able to compile the geolocation dataengine, while applying this \
> patch I can. I have only tested with my GPSD version (2.96), haven't \
> tested with previous versions, however it should work, since for previous \
> versions the calls made are exactly the same as before this patch. Not \
> even unused arguments are created.
>
> Thanks,
>
> Rafael Fernández
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px \
#c9c399 solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101247/">http://git.reviewboard.kde.org/r/101247/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This review has been submitted with commit \
a3009dd96e8519bcc205d75c29e18bbbb81fce03 by Rafael Fernández López.</pre> \
<br />
<p>- Commit</p>
<br />
<p>On April 28th, 2011, 7:16 a.m., Rafael Fernández López wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px \
black solid;"> <tr>
<td>
<div>Review request for Plasma and Petri Damstén.</div>
<div>By Rafael Fernández López.</div>
<p style="color: grey;"><i>Updated April 28, 2011, 7:16 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch fixes compilation when GPSD_API_MAJOR_VERSION >= \
5. The API has changed and some calls are not compatible with the previous \
versions. GPSD version here: 2.96.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I wasn't able to compile the geolocation dataengine, while \
applying this patch I can. I have only tested with my GPSD version (2.96), \
haven't tested with previous versions, however it should work, since \
for previous versions the calls made are exactly the same as before this \
patch. Not even unused arguments are created.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/dataengines/geolocation/location_gps.h <span \
style="color: grey">(506d1d1)</span></li>
<li>plasma/generic/dataengines/geolocation/location_gps.cpp <span \
style="color: grey">(c44cb30)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101247/diff/" \
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic