[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: libRTM: Allow to delete completed task
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2011-04-27 12:29:30
Message-ID: 20110427122930.29331.34203 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101213/#review2920
-----------------------------------------------------------

Ship it!


fine for me

- Marco


On April 23, 2011, 11:31 p.m., Anton Kreuzkamp wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101213/
> -----------------------------------------------------------
> =

> (Updated April 23, 2011, 11:31 p.m.)
> =

> =

> Review request for Plasma.
> =

> =

> Summary
> -------
> =

> I'm mainly filing this review request to be sure that this is indeed a bu=
g and doesn't have a good reason I just cannot see.
> =

> =

> Diffs
> -----
> =

>   libs/rtm/task.cpp de36693 =

> =

> Diff: http://git.reviewboard.kde.org/r/101213/diff
> =

> =

> Testing
> -------
> =

> Compiles and works, as far as I can see.
> =

> =

> Thanks,
> =

> Anton
> =

>


[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/101213/">http://git.reviewboard.kde.org/r/101213/</a>
  </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">fine for me</pre>  <br \
/>







<p>- Marco</p>


<br />
<p>On April 23rd, 2011, 11:31 p.m., Anton Kreuzkamp wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Anton Kreuzkamp.</div>


<p style="color: grey;"><i>Updated April 23, 2011, 11:31 p.m.</i></p>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I&#39;m mainly filing this review request to be sure that this is indeed \
a bug and doesn&#39;t have a good reason I just cannot see.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiles and works, as far as I can see.</pre>  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>libs/rtm/task.cpp <span style="color: grey">(de36693)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/101213/diff/" style="margin-left: \
3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>



_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic