'Review Request: Simplify the comic config ui'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request: Simplify the comic config ui
From:       "Matthias Fuchs" <mat69 () gmx ! net>
Date:       2011-04-27 10:47:17
Message-ID: 20110427104717.19739.192 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101242/
-----------------------------------------------------------

Review request for Plasma and Aaron J. Seigo.

Summary
-------

Removes a lot of options to simplify the comic config.
Amongst them now only tabs are supported instead of also choosing comics vi=
a a combo box. Further if just one entry is selected tabs will be hidden au=
tomatically.
Also option to hide tabs and to change them after a certain time is remvoed.
Where feasible options are on one line now instead of two.

Diffs
-----

  applets/comic/advancedsettings.ui 0d4bde9 =

  applets/comic/comic.h 7134c72 =

  applets/comic/comic.cpp 88a2e31 =

  applets/comic/comicSettings.ui 497ffbb =

  applets/comic/configwidget.h ffc7618 =

  applets/comic/configwidget.cpp d9078d8 =

Diff: http://git.reviewboard.kde.org/r/101242/diff

Testing
-------

Screenshots
-----------

general settings
  http://git.reviewboard.kde.org/r/101242/s/138/
advanced settings
  http://git.reviewboard.kde.org/r/101242/s/139/

Thanks,

Matthias

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/101242/">http://git.reviewboard.kde.org/r/101242/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Aaron J. Seigo.</div>
<div>By Matthias Fuchs.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Removes a lot of options to simplify the comic config. Amongst them now \
only tabs are supported instead of also choosing comics via a combo box. Further if \
just one entry is selected tabs will be hidden automatically. Also option to hide \
tabs and to change them after a certain time is remvoed. Where feasible options are \
on one line now instead of two.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/comic/advancedsettings.ui <span style="color: \
grey">(0d4bde9)</span></li>

 <li>applets/comic/comic.h <span style="color: grey">(7134c72)</span></li>

 <li>applets/comic/comic.cpp <span style="color: grey">(88a2e31)</span></li>

 <li>applets/comic/comicSettings.ui <span style="color: grey">(497ffbb)</span></li>

 <li>applets/comic/configwidget.h <span style="color: grey">(ffc7618)</span></li>

 <li>applets/comic/configwidget.cpp <span style="color: grey">(d9078d8)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/101242/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>

<div>

 <a href="http://git.reviewboard.kde.org/r/101242/s/138/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/04/27/comic_general_400x100.png" \
style="border: 1px black solid;" alt="general settings" /></a>

 <a href="http://git.reviewboard.kde.org/r/101242/s/139/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/04/27/comic_advanced_400x100.png" \
style="border: 1px black solid;" alt="advanced settings" /></a>

</div>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 