'Re: Review Request: Don't create another timeline on every timeout'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Don't create another timeline on every timeout
From:       "Alexey Chernov" <4ernov () gmail ! com>
Date:       2011-04-24 21:25:39
Message-ID: 20110424212539.16819.28393 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101212/
-----------------------------------------------------------

(Updated April 24, 2011, 9:25 p.m.)

Review request for Plasma.

Summary (updated)
-------

Currently RTM plasmoid creates new timeline on every refresh triggered by t=
imeout (usually 5 minutes) of any action with tasks. Timeline is something =
like user session and every user action can be undone while still staying i=
n the same timeline (http://www.rememberthemilk.com/services/api/timelines.=
rtm). I think, creating a new timeline on every refresh isn't so wise, espe=
cially as it triggeres the massive update of all the tasks and lists.

Diffs
-----

  dataengines/rememberthemilk/taskssource.cpp 06d354f9a6facfe8dc1ba42683078=
ab02ff39900 =

Diff: http://git.reviewboard.kde.org/r/101212/diff

Testing
-------

The comment to the line of code says: "Allow us to get new information that=
 people entered on the website or in another api". I tested the version wit=
hout the line quite deeply performing task edits in both RTM web service an=
d plasmoid and they were always synchronized with each other correctly (for=
 plasmoid - as current timeout expired). So I see no reason in this.

Thanks,

Alexey

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/101212/">http://git.reviewboard.kde.org/r/101212/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Alexey Chernov.</div>

<p style="color: grey;"><i>Updated April 24, 2011, 9:25 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description  \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently RTM plasmoid creates new timeline on every refresh triggered \
by timeout (usually 5 minutes) of any action with tasks. Timeline is something like \
user session and every user action can be undone while still staying in the same \
timeline (http://www.rememberthemilk.com/services/api/timelines.rtm). I think, \
creating a new timeline on every refresh isn&#39;t so wise, especially as it \
triggeres the massive update of all the tasks and lists.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The comment to the line of code says: &quot;Allow us to get new \
information that people entered on the website or in another api&quot;. I tested the \
version without the line quite deeply performing task edits in both RTM web service \
and plasmoid and they were always synchronized with each other correctly (for \
plasmoid - as current timeout expired). So I see no reason in this.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>dataengines/rememberthemilk/taskssource.cpp <span style="color: \
grey">(06d354f9a6facfe8dc1ba42683078ab02ff39900)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/101212/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 