From kde-panel-devel Sun Apr 24 21:25:39 2011 From: "Alexey Chernov" <4ernov () gmail ! com> Date: Sun, 24 Apr 2011 21:25:39 +0000 To: kde-panel-devel Subject: Re: Review Request: Don't create another timeline on every timeout Message-Id: <20110424212539.16819.28393 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=130368085129341 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0711945090==" --===============0711945090== Content-Type: multipart/alternative; boundary="===============1802661605981921563==" --===============1802661605981921563== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101212/ ----------------------------------------------------------- (Updated April 24, 2011, 9:25 p.m.) Review request for Plasma. Summary (updated) ------- Currently RTM plasmoid creates new timeline on every refresh triggered by t= imeout (usually 5 minutes) of any action with tasks. Timeline is something = like user session and every user action can be undone while still staying i= n the same timeline (http://www.rememberthemilk.com/services/api/timelines.= rtm). I think, creating a new timeline on every refresh isn't so wise, espe= cially as it triggeres the massive update of all the tasks and lists. Diffs ----- dataengines/rememberthemilk/taskssource.cpp 06d354f9a6facfe8dc1ba42683078= ab02ff39900 = Diff: http://git.reviewboard.kde.org/r/101212/diff Testing ------- The comment to the line of code says: "Allow us to get new information that= people entered on the website or in another api". I tested the version wit= hout the line quite deeply performing task edits in both RTM web service an= d plasmoid and they were always synchronized with each other correctly (for= plasmoid - as current timeout expired). So I see no reason in this. Thanks, Alexey --===============1802661605981921563== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/101212/

Review request for Plasma.

By Alexey Chernov.

Updated April 24, 2011, 9:25 p.m.

Descripti= on (updated)

Currently RTM plasmoid creates new timeline on every refresh=
 triggered by timeout (usually 5 minutes) of any action with tasks. Timelin=
e is something like user session and every user action can be undone while =
still staying in the same timeline (http://www.rememberthemilk.com/services=
/api/timelines.rtm). I think, creating a new timeline on every refresh isn&=
#39;t so wise, especially as it triggeres the massive update of all the tas=
ks and lists.

Testing <= /h1>

The comment to the line of code says: "Allow us to get =
new information that people entered on the website or in another api".=
 I tested the version without the line quite deeply performing task edits i=
n both RTM web service and plasmoid and they were always synchronized with =
each other correctly (for plasmoid - as current timeout expired). So I see =
no reason in this.

Diffs=

dataengines/rememberthemilk/taskssource.cpp View Diff

--===============1802661605981921563==-- --===============0711945090== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============0711945090==--