[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Add "Icons" item to desktop theme details GUI
From: "Commit Hook" <null () kde ! org>
Date: 2011-04-23 9:40:01
Message-ID: 20110423094001.8847.28339 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101175/#review2837
-----------------------------------------------------------
This review has been submitted with commit 6484e9fdc730fdc6d84bc79b1bb1adff=
726a6124 by Jonathan Marten.
- Commit
On April 22, 2011, 1:09 p.m., Jonathan Marten wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101175/
> -----------------------------------------------------------
> =
> (Updated April 22, 2011, 1:09 p.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Summary
> -------
> =
> The "System Settings - Workspace Appearance - Desktop Theme - Details" di=
alogue allows individual theme elements to be selected from any of the avai=
lable desktop themes. However, there is no GUI option to select a theme's =
icons - those stored in the theme's 'icons/' subdirectory and used in the s=
ystem tray. None of the standard KDE themes provide their own icons - they=
all use the default ones from Air - but some themes on kde-look do.
> =
> This 1-line patch adds an "Icons" item to this dialogue. Selecting and c=
opying the icons from a theme is all automatically handled in DesktopThemeD=
etails::save() with no additional code changes being necessary.
> =
> =
> Diffs
> -----
> =
> kcontrol/desktoptheme/desktopthemedetails.cpp 4daced9 =
> =
> Diff: http://git.reviewboard.kde.org/r/101175/diff
> =
> =
> Testing
> -------
> =
> Built kde-workspace with these changes, checked operation of dialogue and=
that theme icons are correctly copied to user's $KDEDIR/share/apps/desktop=
theme/.customized/icons.
> =
> =
> Thanks,
> =
> Jonathan
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101175/">http://git.reviewboard.kde.org/r/101175/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 6484e9fdc730fdc6d84bc79b1bb1adff726a6124 by Jonathan \
Marten.</pre> <br />
<p>- Commit</p>
<br />
<p>On April 22nd, 2011, 1:09 p.m., Jonathan Marten wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Jonathan Marten.</div>
<p style="color: grey;"><i>Updated April 22, 2011, 1:09 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The "System Settings - Workspace Appearance - Desktop Theme - \
Details" dialogue allows individual theme elements to be selected from any of \
the available desktop themes. However, there is no GUI option to select a \
theme's icons - those stored in the theme's 'icons/' subdirectory and \
used in the system tray. None of the standard KDE themes provide their own icons - \
they all use the default ones from Air - but some themes on kde-look do.
This 1-line patch adds an "Icons" item to this dialogue. Selecting and \
copying the icons from a theme is all automatically handled in \
DesktopThemeDetails::save() with no additional code changes being necessary.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Built kde-workspace with these changes, checked operation of dialogue \
and that theme icons are correctly copied to user's \
$KDEDIR/share/apps/desktoptheme/.customized/icons. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcontrol/desktoptheme/desktopthemedetails.cpp <span style="color: \
grey">(4daced9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101175/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic