--===============1382614752== Content-Type: multipart/alternative; boundary="===============6899273245716856951==" --===============6899273245716856951== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101175/#review2837 ----------------------------------------------------------- This review has been submitted with commit 6484e9fdc730fdc6d84bc79b1bb1adff= 726a6124 by Jonathan Marten. - Commit On April 22, 2011, 1:09 p.m., Jonathan Marten wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101175/ > ----------------------------------------------------------- > = > (Updated April 22, 2011, 1:09 p.m.) > = > = > Review request for Plasma. > = > = > Summary > ------- > = > The "System Settings - Workspace Appearance - Desktop Theme - Details" di= alogue allows individual theme elements to be selected from any of the avai= lable desktop themes. However, there is no GUI option to select a theme's = icons - those stored in the theme's 'icons/' subdirectory and used in the s= ystem tray. None of the standard KDE themes provide their own icons - they= all use the default ones from Air - but some themes on kde-look do. > = > This 1-line patch adds an "Icons" item to this dialogue. Selecting and c= opying the icons from a theme is all automatically handled in DesktopThemeD= etails::save() with no additional code changes being necessary. > = > = > Diffs > ----- > = > kcontrol/desktoptheme/desktopthemedetails.cpp 4daced9 = > = > Diff: http://git.reviewboard.kde.org/r/101175/diff > = > = > Testing > ------- > = > Built kde-workspace with these changes, checked operation of dialogue and= that theme icons are correctly copied to user's $KDEDIR/share/apps/desktop= theme/.customized/icons. > = > = > Thanks, > = > Jonathan > = > --===============6899273245716856951== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/101175/

This revie=
w has been submitted with commit 6484e9fdc730fdc6d84bc79b1bb1adff726a6124 b=
y Jonathan Marten.

- Commit

On April 22nd, 2011, 1:09 p.m., Jonathan Marten wrote:

Review request for Plasma.

By Jonathan Marten.

Updated April 22, 2011, 1:09 p.m.

Descripti= on

The "System Settings - Workspace Appearance - Desktop T=
heme - Details" dialogue allows individual theme elements to be select=
ed from any of the available desktop themes.  However, there is no GUI opti=
on to select a theme's icons - those stored in the theme's 'ico=
ns/' subdirectory and used in the system tray.  None of the standard KD=
E themes provide their own icons - they all use the default ones from Air -=
 but some themes on kde-look do.

This 1-line patch adds an "Icons" item to this dialogue.  Selecti=
ng and copying the icons from a theme is all automatically handled in Deskt=
opThemeDetails::save() with no additional code changes being necessary.

Testing <= /h1>

Built kde-workspace with these changes, checked operation of=
 dialogue and that theme icons are correctly copied to user's $KDEDIR/s=
hare/apps/desktoptheme/.customized/icons.

Diffs=

kcontrol/desktoptheme/desktopthemedetails.cpp (4daced9)

--===============6899273245716856951==-- --===============1382614752== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============1382614752==--