[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Option to set no title for the folderview applet
From: "J Janz" <kde () juniorjanz ! net>
Date: 2011-03-03 16:16:49
Message-ID: 20110303161649.3267.46329 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Feb. 28, 2011, 3:45 p.m., Sebastian K=C3=BCgler wrote:
> > There's no need to add a UI option for this, the user should just be ab=
le to set an empty title and the header would then get hidden / collapsed.
> > =
> > Right now, this doesn't happen since when the label is empty, the defau=
lt gets chosen. So this mechanism needs to be a bit smarter to detect when =
the user has actually set an empty title (which is different from title.isE=
mpty() so set default name).
> =
> Farhad Hedayati Fard wrote:
> How should I know whether the user has set the title empty to make th=
e header hidden or by doing so he/she means to choose the default title ins=
tead of being hidden? I think It either needs a UI option or some special v=
alue in the custom title... =
> Maybe I don't get what you're saying, can you please explain a little=
more? =
> Thanks :)
If I may try to help, I'd suggest something, IMHO, a bit easier to understa=
nd at first sight: changing 4.6's "Custom Title" line for a checkbox (meani=
ng title or no title), a label "Title" and edit box. Something like: [X] Ti=
tle: [Default_______]
Then, leaving the edit box blank is default title (and, yeah, it could disp=
lay "Default" at first time and right when cleared) or, sure, if user touch=
ed it, that's the title's value.
- J
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100750/#review1698
-----------------------------------------------------------
On March 3, 2011, 1:39 p.m., Farhad Hedayati Fard wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100750/
> -----------------------------------------------------------
> =
> (Updated March 3, 2011, 1:39 p.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Summary
> -------
> =
> Let the user set a blank label. The label should not take up any space wh=
en it is blank.
> =
> =
> Diffs
> -----
> =
> plasma/applets/folderview/folderview.h 2241b12 =
> plasma/applets/folderview/folderview.cpp f604277 =
> =
> Diff: http://git.reviewboard.kde.org/r/100750/diff
> =
> =
> Testing
> -------
> =
> Works fine here! =
> =
> =
> Screenshots
> -----------
> =
> folderview configuration dialog
> http://git.reviewboard.kde.org/r/100750/s/84/
> folderview with blank label
> http://git.reviewboard.kde.org/r/100750/s/85/
> =
> =
> Thanks,
> =
> Farhad
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100750/">http://git.reviewboard.kde.org/r/100750/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 28th, 2011, 3:45 p.m., <b>Sebastian \
Kügler</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">There's no need to add a UI option for this, the user should just be \
able to set an empty title and the header would then get hidden / collapsed.
Right now, this doesn't happen since when the label is empty, the default gets \
chosen. So this mechanism needs to be a bit smarter to detect when the user has \
actually set an empty title (which is different from title.isEmpty() so set default \
name).</pre> </blockquote>
<p>On March 1st, 2011, 4:05 p.m., <b>Farhad Hedayati Fard</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">How should I know \
whether the user has set the title empty to make the header hidden or by doing so \
he/she means to choose the default title instead of being hidden? I think It either \
needs a UI option or some special value in the custom title... Maybe I don't get \
what you're saying, can you please explain a little more? Thanks :)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If I may try to help, \
I'd suggest something, IMHO, a bit easier to understand at first sight: changing \
4.6's "Custom Title" line for a checkbox (meaning title or no title), a \
label "Title" and edit box. Something like: [X] Title: [Default_______]
Then, leaving the edit box blank is default title (and, yeah, it could display \
"Default" at first time and right when cleared) or, sure, if user touched \
it, that's the title's value.</pre> <br />
<p>- J</p>
<br />
<p>On March 3rd, 2011, 1:39 p.m., Farhad Hedayati Fard wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Farhad Hedayati Fard.</div>
<p style="color: grey;"><i>Updated March 3, 2011, 1:39 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Let the user set a blank label. The label should not take up any space \
when it is blank.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works fine here! </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/applets/folderview/folderview.h <span style="color: \
grey">(2241b12)</span></li>
<li>plasma/applets/folderview/folderview.cpp <span style="color: \
grey">(f604277)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100750/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/100750/s/84/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/02/26/folderview_settings_400x100.png" \
style="border: 1px black solid;" alt="folderview configuration dialog" /></a>
<a href="http://git.reviewboard.kde.org/r/100750/s/85/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/02/26/folderview_400x100.png" \
style="border: 1px black solid;" alt="folderview with blank label" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic