[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Option to set no title for the folderview applet
From: "Farhad Hedayati Fard" <hf.farhad () gmail ! com>
Date: 2011-03-03 13:39:01
Message-ID: 20110303133901.30168.32665 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100750/
-----------------------------------------------------------
(Updated March 3, 2011, 1:39 p.m.)
Review request for Plasma.
Changes
-------
removed the UI option, now an autocompletion box is opened whenever the use=
r wants to edit the title, it has three values :
* Empty
* Default title
* Full path =
If the user enters nothing (labelEdit.isEmpty()) "Empty" is used but the te=
xt of labelEdit is changed to "Empty" next time the user opens the config d=
ialog.
Also, If "Default title" or "Full path" is chosen, labelEdit shows these va=
lues instead of the actual default title or full path...
Summary
-------
Let the user set a blank label. The label should not take up any space when=
it is blank.
Diffs (updated)
-----
plasma/applets/folderview/folderview.h 2241b12 =
plasma/applets/folderview/folderview.cpp f604277 =
Diff: http://git.reviewboard.kde.org/r/100750/diff
Testing
-------
Works fine here! =
Screenshots
-----------
folderview configuration dialog
http://git.reviewboard.kde.org/r/100750/s/84/
folderview with blank label
http://git.reviewboard.kde.org/r/100750/s/85/
Thanks,
Farhad
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100750/">http://git.reviewboard.kde.org/r/100750/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Farhad Hedayati Fard.</div>
<p style="color: grey;"><i>Updated March 3, 2011, 1:39 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">removed the UI option, now an autocompletion box is opened whenever the \
user wants to edit the title, it has three values :
* Empty
* Default title
* Full path
If the user enters nothing (labelEdit.isEmpty()) "Empty" is used but the \
text of labelEdit is changed to "Empty" next time the user opens the config \
dialog. Also, If "Default title" or "Full path" is chosen, \
labelEdit shows these values instead of the actual default title or full path...
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Let the user set a blank label. The label should not take up any space \
when it is blank.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works fine here! </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/applets/folderview/folderview.h <span style="color: \
grey">(2241b12)</span></li>
<li>plasma/applets/folderview/folderview.cpp <span style="color: \
grey">(f604277)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100750/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/100750/s/84/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/02/26/folderview_settings_400x100.png" \
style="border: 1px black solid;" alt="folderview configuration dialog" /></a>
<a href="http://git.reviewboard.kde.org/r/100750/s/85/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/02/26/folderview_400x100.png" \
style="border: 1px black solid;" alt="folderview with blank label" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic